minor #43847 [RateLimiter] Increase delta in limiter tests (wkania)

fabpot · fabpot · commit f3c19ed8dc91 · 2021-11-01T08:02:38.000+01:00
This PR was merged into the 5.3 branch. Discussion ---------- [RateLimiter] Increase delta in limiter tests | Q | A | ------------- | --- | Branch? | 5.3  | Bug fix? | yes | New feature? | no  | Deprecations? | no  | License | MIT Tests from [PR](#42168) might randomly fail [1](https://ci.appveyor.com/project/fabpot/symfony/builds/41346868#L597) [2](https://ci.appveyor.com/project/fabpot/symfony/builds/41346183#L650) I increased delta like in [this test](https://github.com/symfony/symfony/blob/5.3/src/Symfony/Component/RateLimiter/Tests/Policy/TokenBucketLimiterTest.php#L90). ![image](https://user-images.githubusercontent.com/57155526/139543405-e8e1b760-96b2-4aea-8ed2-15c6221cd387.png) ![image](https://user-images.githubusercontent.com/57155526/139543418-d9558c2e-9248-49dd-b941-ad917f5e23d2.png) `@fabpot` `@Nyholm` please review Commits ------- 3e2ca33 [RateLimiter] Increase delta in limiter tests
diff --git a/src/Symfony/Component/RateLimiter/Tests/Policy/FixedWindowLimiterTest.php b/src/Symfony/Component/RateLimiter/Tests/Policy/FixedWindowLimiterTest.php
@@ -78,7 +78,7 @@ public function testWaitIntervalOnConsumeOverLimit()
 
         $start = microtime(true);
         $rateLimit->wait(); // wait 1 minute
-        $this->assertEqualsWithDelta($start + 60, microtime(true), 0.5);
+        $this->assertEqualsWithDelta($start + 60, microtime(true), 1);
     }
 
     public function testWrongWindowFromCache()
diff --git a/src/Symfony/Component/RateLimiter/Tests/Policy/SlidingWindowLimiterTest.php b/src/Symfony/Component/RateLimiter/Tests/Policy/SlidingWindowLimiterTest.php
@@ -66,7 +66,7 @@ public function testWaitIntervalOnConsumeOverLimit()
 
         $start = microtime(true);
         $rateLimit->wait(); // wait 12 seconds
-        $this->assertEqualsWithDelta($start + 12, microtime(true), 0.5);
+        $this->assertEqualsWithDelta($start + 12, microtime(true), 1);
     }
 
     public function testReserve()
diff --git a/src/Symfony/Component/RateLimiter/Tests/Policy/TokenBucketLimiterTest.php b/src/Symfony/Component/RateLimiter/Tests/Policy/TokenBucketLimiterTest.php
@@ -102,7 +102,7 @@ public function testWaitIntervalOnConsumeOverLimit()
 
         $start = microtime(true);
         $rateLimit->wait(); // wait 1 second
-        $this->assertEqualsWithDelta($start + 1, microtime(true), 0.5);
+        $this->assertEqualsWithDelta($start + 1, microtime(true), 1);
     }
 
     public function testWrongWindowFromCache()

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ public function testWaitIntervalOnConsumeOverLimit()`
`78`	`78`
`79`	`79`	`$start = microtime(true);`
`80`	`80`	`$rateLimit->wait(); // wait 1 minute`
`81`		`- $this->assertEqualsWithDelta($start + 60, microtime(true), 0.5);`
	`81`	`+ $this->assertEqualsWithDelta($start + 60, microtime(true), 1);`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`public function testWrongWindowFromCache()`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ public function testWaitIntervalOnConsumeOverLimit()`
`66`	`66`
`67`	`67`	`$start = microtime(true);`
`68`	`68`	`$rateLimit->wait(); // wait 12 seconds`
`69`		`- $this->assertEqualsWithDelta($start + 12, microtime(true), 0.5);`
	`69`	`+ $this->assertEqualsWithDelta($start + 12, microtime(true), 1);`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`public function testReserve()`
Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ public function testWaitIntervalOnConsumeOverLimit()`
`102`	`102`
`103`	`103`	`$start = microtime(true);`
`104`	`104`	`$rateLimit->wait(); // wait 1 second`
`105`		`- $this->assertEqualsWithDelta($start + 1, microtime(true), 0.5);`
	`105`	`+ $this->assertEqualsWithDelta($start + 1, microtime(true), 1);`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`public function testWrongWindowFromCache()`