bug #20375 [HttpFoundation][Session] Fix memcache session handler (klandaika)

fabpot · fabpot · commit f37ac131e120 · 2016-11-04T08:14:52.000-07:00
This PR was merged into the 2.7 branch. Discussion ---------- [HttpFoundation][Session] Fix memcache session handler | Q | A | ------------- | --- | Branch? | 2.1, 2.2, 2.3, 2.4, 2.5, 2.6, 2.7, 2.8, 3.0, 3.1, master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commit 0216e05 removed the opening of connection to memcached server on call to `open()`, because it's assumed that connection is already opened. However, `close()` still closes the connection. As a result no more read/write calls can be made if session got closed, as the connection does not get reestablished. Basically MemcacheSessionHandler should follow same logic as Memcache**d**SessionHandler, which is exactly what this MR acomplishes. Commits ------- 0423d89 [HttpFoundation][Session] memcached connection should not be closed
diff --git a/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/MemcacheSessionHandler.php b/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/MemcacheSessionHandler.php
@@ -71,7 +71,7 @@ public function open($savePath, $sessionName)
      */
     public function close()
     {
-        return $this->memcache->close();
+        return true;
     }
 
     /**
diff --git a/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcacheSessionHandlerTest.php b/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcacheSessionHandlerTest.php
@@ -56,12 +56,6 @@ public function testOpenSession()
 
     public function testCloseSession()
     {
-        $this->memcache
-            ->expects($this->once())
-            ->method('close')
-            ->will($this->returnValue(true))
-        ;
-
         $this->assertTrue($this->storage->close());
     }
 

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ public function open($savePath, $sessionName)`
`71`	`71`	`*/`
`72`	`72`	`public function close()`
`73`	`73`	`{`
`74`		`- return $this->memcache->close();`
	`74`	`+ return true;`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -56,12 +56,6 @@ public function testOpenSession()`
`56`	`56`
`57`	`57`	`public function testCloseSession()`
`58`	`58`	`{`
`59`		`- $this->memcache`
`60`		`- ->expects($this->once())`
`61`		`- ->method('close')`
`62`		`- ->will($this->returnValue(true))`
`63`		`- ;`
`64`		`-`
`65`	`59`	`$this->assertTrue($this->storage->close());`
`66`	`60`	`}`
`67`	`61`