bug #50093 [RemoteEvent] Fix ConsumerInterface usage (fabpot)

fabpot · fabpot · commit f2b7403bd99c · 2023-04-21T17:11:52.000+02:00
This PR was merged into the 6.3 branch. Discussion ---------- [RemoteEvent] Fix ConsumerInterface usage | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | Fix #50025 | License | MIT | Doc PR | Commits ------- f5d874e [RemoteEvent] Fix ConsumerInterface usage
diff --git a/src/Symfony/Component/RemoteEvent/Messenger/ConsumeRemoteEventHandler.php b/src/Symfony/Component/RemoteEvent/Messenger/ConsumeRemoteEventHandler.php
@@ -12,6 +12,7 @@
 namespace Symfony\Component\RemoteEvent\Messenger;
 
 use Psr\Container\ContainerInterface;
+use Symfony\Component\RemoteEvent\Consumer\ConsumerInterface;
 use Symfony\Component\RemoteEvent\Exception\LogicException;
 
 /**
@@ -33,6 +34,10 @@ public function __invoke(ConsumeRemoteEventMessage $message): void
         }
         $consumer = $this->consumers->get($message->getType());
 
+        if (!$consumer instanceof ConsumerInterface) {
+            throw new LogicException(sprintf('The consumer "%s" for message of type "%s" must implement "%s".', get_debug_type($consumer), $message->getType(), ConsumerInterface::class));
+        }
+
         $consumer->consume($message->getEvent());
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`	`namespace Symfony\Component\RemoteEvent\Messenger;`
`13`	`13`
`14`	`14`	`use Psr\Container\ContainerInterface;`
	`15`	`+use Symfony\Component\RemoteEvent\Consumer\ConsumerInterface;`
`15`	`16`	`use Symfony\Component\RemoteEvent\Exception\LogicException;`
`16`	`17`
`17`	`18`	`/**`
`@@ -33,6 +34,10 @@ public function __invoke(ConsumeRemoteEventMessage $message): void`
`33`	`34`	`}`
`34`	`35`	`$consumer = $this->consumers->get($message->getType());`
`35`	`36`
	`37`	`+ if (!$consumer instanceof ConsumerInterface) {`
	`38`	`+ throw new LogicException(sprintf('The consumer "%s" for message of type "%s" must implement "%s".', get_debug_type($consumer), $message->getType(), ConsumerInterface::class));`
	`39`	`+ }`
	`40`	`+`
`36`	`41`	`$consumer->consume($message->getEvent());`
`37`	`42`	`}`
`38`	`43`	`}`