[HttpKernel] Revise MongoDbProfilerStorage::write() return value

jmikola · jmikola · commit f24e3d79eab7 · 2012-12-13T16:41:47.000-05:00
This should be functionally equivalent, but will be more robust if update() ever returns a falsey value.
diff --git a/src/Symfony/Component/HttpKernel/Profiler/MongoDbProfilerStorage.php b/src/Symfony/Component/HttpKernel/Profiler/MongoDbProfilerStorage.php
@@ -104,7 +104,7 @@ public function write(Profile $profile)
 
         $result = $this->getMongo()->update(array('_id' => $profile->getToken()), array_filter($record, function ($v) { return !empty($v); }), array('upsert' => true));
 
-        return isset($result['ok']) ? (boolean) $result['ok'] : true;
+        return (boolean) (isset($result['ok']) ? $result['ok'] : $result);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ public function write(Profile $profile)`
`104`	`104`
`105`	`105`	`$result = $this->getMongo()->update(array('_id' => $profile->getToken()), array_filter($record, function ($v) { return !empty($v); }), array('upsert' => true));`
`106`	`106`
`107`		`- return isset($result['ok']) ? (boolean) $result['ok'] : true;`
	`107`	`+ return (boolean) (isset($result['ok']) ? $result['ok'] : $result);`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`/**`