fix: respect array keys while denormalizing variadic parameters

melya · melya · commit f18533d02e35 · 2023-03-06T17:02:30.000+01:00
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
@@ -343,8 +343,8 @@ protected function instantiateObject(array &$data, string $class, array &$contex
                         }
 
                         $variadicParameters = [];
-                        foreach ($data[$paramName] as $parameterData) {
-                            $variadicParameters[] = $this->denormalizeParameter($reflectionClass, $constructorParameter, $paramName, $parameterData, $attributeContext, $format);
+                        foreach ($data[$paramName] as $parameterKey => $parameterData) {
+                            $variadicParameters[$parameterKey] = $this->denormalizeParameter($reflectionClass, $constructorParameter, $paramName, $parameterData, $attributeContext, $format);
                         }
 
                         $params = array_merge($params, $variadicParameters);

Original file line number	Diff line number	Diff line change
`@@ -343,8 +343,8 @@ protected function instantiateObject(array &$data, string $class, array &$contex`
`343`	`343`	`}`
`344`	`344`
`345`	`345`	`$variadicParameters = [];`
`346`		`- foreach ($data[$paramName] as $parameterData) {`
`347`		`- $variadicParameters[] = $this->denormalizeParameter($reflectionClass, $constructorParameter, $paramName, $parameterData, $attributeContext, $format);`
	`346`	`+ foreach ($data[$paramName] as $parameterKey => $parameterData) {`
	`347`	`+ $variadicParameters[$parameterKey] = $this->denormalizeParameter($reflectionClass, $constructorParameter, $paramName, $parameterData, $attributeContext, $format);`
`348`	`348`	`}`
`349`	`349`
`350`	`350`	`$params = array_merge($params, $variadicParameters);`