[FrameworkBundle] display actual target for error in AssetsInstallCommand

NerdyProjects · nicolas-grekas · commit f177b3d4885a · 2020-05-08T11:56:06.000+02:00
When assets:install fails because the target directory does not exist, it should display the actual directory it wanted to have instead of the configuration directive. In most cases, the target directory is retrieved from the kernel config and thus differs from the argument.
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php
@@ -121,7 +121,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 if (is_dir(\dirname($targetArg).'/web')) {
                     $targetArg = \dirname($targetArg).'/web';
                 } else {
-                    throw new InvalidArgumentException(sprintf('The target directory "%s" does not exist.', $input->getArgument('target')));
+                    throw new InvalidArgumentException(sprintf('The target directory "%s" does not exist.', $targetArg));
                 }
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`121`	`121`	`if (is_dir(\dirname($targetArg).'/web')) {`
`122`	`122`	`$targetArg = \dirname($targetArg).'/web';`
`123`	`123`	`} else {`
`124`		`- throw new InvalidArgumentException(sprintf('The target directory "%s" does not exist.', $input->getArgument('target')));`
	`124`	`+ throw new InvalidArgumentException(sprintf('The target directory "%s" does not exist.', $targetArg));`
`125`	`125`	`}`
`126`	`126`	`}`
`127`	`127`	`}`