8000 minor #23123 Add tests for ResponseCacheStrategy to document some mor… · symfony/symfony@f0abe11 · GitHub
[go: up one dir, main page]
Skip to content

Commit f0abe11

Browse files
fabpotfabpot
committed
minor #23123 Add tests for ResponseCacheStrategy to document some more edge cases (mpdude)
This PR was squashed before being merged into the 2.7 branch (closes #23123). Discussion ---------- Add tests for ResponseCacheStrategy to document some more edge cases | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Adds some test cases for possible combinations of master/subrequest responses to better document behaviour in edge cases. Should now cover the entire `ResponseCacheStrategy`. I hope 2.7 is the right target branch because having more tests for all releases should be a good thing:tm:. Commits ------- 69e8463 Add tests for ResponseCacheStrategy to document some more edge cases
2 parents 4cff052 + 69e8463 commit f0abe11

File tree

1 file changed

+62
-0
lines changed

1 file changed

+62
-0
lines changed

‎src/Symfony/Component/HttpKernel/Tests/HttpCache/ResponseCacheStrategyTest.php

Lines changed: 62 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,4 +75,66 @@ public function testSharedMaxAgeNotSetIfNotSetInMasterRequest()
7575

7676
$this->assertFalse($response->headers->hasCacheControlDirective('s-maxage'));
7777
}
78+
79+
public function testMasterResponseNotCacheableWhenEmbeddedResponseRequiresValidation()
80+
{
81+
$cacheStrategy = new ResponseCacheStrategy();
82+
83+
$embeddedResponse = new Response();
84+
$embeddedResponse->setLastModified(new \DateTime());
85+
$cacheStrategy->add($embeddedResponse);
86+
87+
$masterResponse = new Response();
88+
$masterResponse->setSharedMaxAge(3600);
89+
$cacheStrategy->update($masterResponse);
90+
91+
$this->assertTrue($masterResponse->headers->hasCacheControlDirective('no-cache'));
92+
$this->assertTrue($masterResponse->headers->hasCacheControlDirective('must-revalidate'));
93+
$this->assertFalse($masterResponse->isFresh());
94+
}
95+
96+
public function testValidationOnMasterResponseIsNotPossibleWhenItContainsEmbeddedResponses()
97+
{
98+
$cacheStrategy = new ResponseCacheStrategy();
99+
100+
// This master response uses the "validation" model
101+
$masterResponse = new Response();
102+
$masterResponse->setLastModified(new \DateTime());
103+
$masterResponse->setEtag('foo');
104+
105+
// Embedded response uses "expiry" model
106+
$embeddedResponse = new Response();
107+
$masterResponse->setSharedMaxAge(3600);
108+
$cacheStrategy->add($embeddedResponse);
109+
110+
$cacheStrategy->update($masterResponse);
111+
112+
$this->assertFalse($masterResponse->isValidateable());
113+
$this->assertFalse($masterResponse->headers->has('Last-Modified'));
114+
$this->assertFalse($masterResponse->headers->has('ETag'));
115+
$this->assertTrue($masterResponse->headers->hasCacheControlDirective('no-cache'));
116+
$this->assertTrue($masterResponse->headers->hasCacheControlDirective('must-revalidate'));
117+
}
118+
119+
public function testMasterResponseWithValidationIsUnchangedWhenThereIsNoEmbeddedResponse()
120+
{
121+
$cacheStrategy = new ResponseCacheStrategy();
122+
123+
$masterResponse = new Response();
124+
$masterResponse->setLastModified(new \DateTime());
125+
$cacheStrategy->update($masterResponse);
126+
127+
$this->assertTrue($masterResponse->isValidateable());
128+
}
129+
130+
public function testMasterResponseWithExpirationIsUnchangedWhenThereIsNoEmbeddedResponse()
131+
{
132+
$cacheStrategy = new ResponseCacheStrategy();
133+
134+
$masterResponse = new Response();
135+
$masterResponse->setSharedMaxAge(3600);
136+
$cacheStrategy->update($masterResponse);
137+
138+
$this->assertTrue($masterResponse->isFresh());
139+
}
78140
}

0 commit comments

Comments
 (0)
0