minor #38797 Fix transient tests on branch 3.4 (jderusse)

nicolas-grekas · nicolas-grekas · commit f04745a20875 · 2020-10-27T10:55:27.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- Fix transient tests on branch 3.4 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Fix transient tests on branch 3.4. I'll keep this PR open few days to watch travis/GHA for transient tests Commits ------- 987efdd Fix transient tests
diff --git a/src/Symfony/Component/HttpKernel/Tests/HttpCache/ResponseCacheStrategyTest.php b/src/Symfony/Component/HttpKernel/Tests/HttpCache/ResponseCacheStrategyTest.php
@@ -216,7 +216,7 @@ public function testResponseIsExiprableWhenEmbeddedResponseCombinesExpiryAndVali
         $cacheStrategy->add($embeddedResponse);
         $cacheStrategy->update($masterResponse);
 
-        $this->assertSame('60', $masterResponse->headers->getCacheControlDirective('s-maxage'));
+        $this->assertEqualsWithDelta(60, (int) $masterResponse->headers->getCacheControlDirective('s-maxage'), 1);
     }
 
     public function testResponseIsExpirableButNotValidateableWhenMasterResponseCombinesExpirationAndValidation()

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ public function testResponseIsExiprableWhenEmbeddedResponseCombinesExpiryAndVali`
`216`	`216`	`$cacheStrategy->add($embeddedResponse);`
`217`	`217`	`$cacheStrategy->update($masterResponse);`
`218`	`218`
`219`		`- $this->assertSame('60', $masterResponse->headers->getCacheControlDirective('s-maxage'));`
	`219`	`+ $this->assertEqualsWithDelta(60, (int) $masterResponse->headers->getCacheControlDirective('s-maxage'), 1);`
`220`	`220`	`}`
`221`	`221`
`222`	`222`	`public function testResponseIsExpirableButNotValidateableWhenMasterResponseCombinesExpirationAndValidation()`