8000 minor #38797 Fix transient tests on branch 3.4 (jderusse) · symfony/symfony@f04745a · GitHub
[go: up one dir, main page]

Skip to content
8000

Commit f04745a

Browse files
minor #38797 Fix transient tests on branch 3.4 (jderusse)
This PR was merged into the 3.4 branch. Discussion ---------- Fix transient tests on branch 3.4 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Fix transient tests on branch 3.4. I'll keep this PR open few days to watch travis/GHA for transient tests Commits ------- 987efdd Fix transient tests
2 parents eec6fd5 + 987efdd commit f04745a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Symfony/Component/HttpKernel/Tests/HttpCache/ResponseCacheStrategyTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ public function testResponseIsExiprableWhenEmbeddedResponseCombinesExpiryAndVali
216216
$cacheStrategy->add($embeddedResponse);
217217
$cacheStrategy->update($masterResponse);
218218

219-
$this->assertSame('60', $masterResponse->headers->getCacheControlDirective('s-maxage'));
219+
$this->assertEqualsWithDelta(60, (int) $masterResponse->headers->getCacheControlDirective('s-maxage'), 1);
220220
}
221221

222222
public function testResponseIsExpirableButNotValidateableWhenMasterResponseCombinesExpirationAndValidation()

0 commit comments

Comments
 (0)
0