8000 fixed functional tests so that the cache/logs are specific to one ver… · symfony/symfony@f03692a · GitHub
[go: up one dir, main page]
Skip to content

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit f03692a

Browse files
fabpotfabpot
committed
fixed functional tests so that the cache/logs are specific to one version of Symfony (to avoid weird side effects)
1 parent 8579c63 commit f03692a

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Tests/Functional/WebTestCase.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
use Symfony\Component\HttpKernel\Util\Filesystem;
1515
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase as BaseWebTestCase;
16+
use Symfony\Component\HttpKernel\Kernel;
1617

1718
class WebTestCase extends BaseWebTestCase
1819
{
@@ -33,7 +34,7 @@ protected function setUp()
3334

3435
protected function deleteTmpDir($testCase)
3536
{
36-
if (!file_exists($dir = sys_get_temp_dir().'/'.$testCase)) {
37+
if (!file_exists($dir = sys_get_temp_dir().'/'.Kernel::VERSION.'/'.$testCase)) {
3738
return;
3839
}
3940

‎src/Symfony/Bundle/FrameworkBundle/Tests/Functional/app/AppKernel.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,12 +80,12 @@ public function getRootDir()
8080

8181
public function getCacheDir()
8282
{
83-
return sys_get_temp_dir().'/'.$this->testCase.'/cache/'.$this->environment;
83+
return sys_get_temp_dir().'/'.Kernel::VERSION.'/'.$this->testCase.'/cache/'.$this->environment;
8484
}
8585

8686
public function getLogDir()
8787
{
88-
return sys_get_temp_dir().'/'.$this->testCase.'/logs';
88+
return sys_get_temp_dir().'/'.Kernel::VERSION.'/'.$this->testCase.'/logs';
8989
}
9090

9191
public function registerContainerConfiguration(LoaderInterface $loader)

‎src/Symfony/Bundle/SecurityBundle/Tests/Functional/WebTestCase.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
use Symfony\Component\HttpKernel\Util\Filesystem;
1515
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase as BaseWebTestCase;
16+
use Symfony\Component\HttpKernel\Kernel;
1617

1718
class WebTestCase extends BaseWebTestCase
1819
{
@@ -33,7 +34,7 @@ protected function setUp()
3334

3435
protected function deleteTmpDir($testCase)
3536
{
36-
if (!file_exists($dir = sys_get_temp_dir().'/'.$testCase)) {
37+
if (!file_exists($dir = sys_get_temp_dir().'/'.Kernel::VERSION.'/'.$testCase)) {
3738
return;
3839
}
3940

‎src/Symfony/Bundle/SecurityBundle/Tests/Functional/app/AppKernel.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,12 +80,12 @@ public function getRootDir()
8080

8181
public function getCacheDir()
8282
{
83-
return sys_get_temp_dir().'/'.$this->testCase.'/cache/'.$this->environment;
83+
return sys_get_temp_dir().'/'.Kernel::VERSION.'/'.$this->testCase.'/cache/'.$this->environment;
8484
}
8585

8686
public function getLogDir()
8787
{
88-
return sys_get_temp_dir().'/'.$this->testCase.'/logs';
88+
return sys_get_temp_dir().'/'.Kernel::VERSION.'/'.$this->testCase.'/logs';
8989
}
9090

9191
public function registerContainerConfiguration(LoaderInterface $loader)

0 commit comments

Comments
 (0)
0