bug #18765 Catch \Throwable (fprochazka)

fabpot · fabpot · commit eff863b434af · 2016-05-23T11:00:59.000+02:00
This PR was merged into the 2.8 branch. Discussion ---------- Catch \Throwable | Q | A | ------------- | --- | Branch? | 2.8, 3.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | Mostly! | Fixed tickets | n/a | License | MIT | Doc PR | n/a The first commit is based on #15949 Depends on #18813, #18812 ---- I'm new to symfony, so I'm not sure where are all the places where it makes sense to actually catch the throwable and where not. I added most places that seemed logical and when I wasn't sure, I added it anyway. I'm hoping you guys (and girls?) can point out the places where the catch should not be added, I'll fix it and then I can create several PR's for the older branches. A lot of this IMHO should go also to 3.0. Commits ------- de671f4 Catch \Throwable
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php b/src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
@@ -44,8 +44,8 @@ public function process(ContainerBuilder $container)
                     $this->completeDefinition($id, $definition);
                 }
             }
-        } catch (\Error $e) {
         } catch (\Exception $e) {
+        } catch (\Throwable $e) {
         }
 
         spl_autoload_unregister($throwingAutoloader);

Original file line number	Diff line number	Diff line change
`@@ -44,8 +44,8 @@ public function process(ContainerBuilder $container)`
`44`	`44`	`$this->completeDefinition($id, $definition);`
`45`	`45`	`}`
`46`	`46`	`}`
`47`		`- } catch (\Error $e) {`
`48`	`47`	`} catch (\Exception $e) {`
	`48`	`+ } catch (\Throwable $e) {`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`spl_autoload_unregister($throwingAutoloader);`