feature #40992 [Notifier] Add SlackOptions::threadTs() to send message as reply (WaylandAce)

nicolas-grekas · nicolas-grekas · commit ef2da6c887ff · 2021-05-06T21:01:04.000+02:00
This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] Add SlackOptions::threadTs() to send message as reply | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | no | License | MIT | Doc PR | no Allow specify argument [thread_ts](https://api.slack.com/methods/chat.postMessage#arg_thread_ts) to send reply message. Commits ------- d3807a7 [Notifier] Add SlackOptions::threadTs() to send message as reply
diff --git a/src/Symfony/Component/Notifier/Bridge/Slack/CHANGELOG.md b/src/Symfony/Component/Notifier/Bridge/Slack/CHANGELOG.md
@@ -8,6 +8,7 @@ CHANGELOG
  * Check for maximum number of buttons in Slack action block
  * Add HeaderBlock
  * Slack access tokens needs to start with "xox" (see https://api.slack.com/authentication/token-types)
+ * Add `SlackOptions::threadTs()` to send message as reply
 
 5.2.0
 -----
diff --git a/src/Symfony/Component/Notifier/Bridge/Slack/SlackOptions.php b/src/Symfony/Component/Notifier/Bridge/Slack/SlackOptions.php
@@ -181,4 +181,14 @@ public function username(string $username): self
 
         return $this;
     }
+
+    /**
+     * @return $this
+     */
+    public function threadTs(string $threadTs): self
+    {
+        $this->options['thread_ts'] = $threadTs;
+
+        return $this;
+    }
 }
diff --git a/src/Symfony/Component/Notifier/Bridge/Slack/Tests/SlackOptionsTest.php b/src/Symfony/Component/Notifier/Bridge/Slack/Tests/SlackOptionsTest.php
@@ -70,6 +70,7 @@ public function toArraySimpleOptionsProvider(): iterable
         yield [['unfurl_links' => true]];
         yield [['unfurl_media' => true]];
         yield [['username' => 'baz']];
+        yield [['thread_ts' => '1503435956.000247']];
     }
 
     /**
@@ -111,6 +112,7 @@ public function setProvider(): iterable
         yield ['unfurlLinks', 'unfurl_links', true];
         yield ['unfurlMedia', 'unfurl_media', true];
         yield ['username', 'username', 'baz'];
+        yield ['threadTs', 'thread_ts', '1503435956.000247'];
     }
 
     public function testSetBlock()

Original file line number	Diff line number	Diff line change
`@@ -181,4 +181,14 @@ public function username(string $username): self`
`181`	`181`
`182`	`182`	`return $this;`
`183`	`183`	`}`
	`184`	`+`
	`185`	`+ /**`
	`186`	`+ * @return $this`
	`187`	`+ */`
	`188`	`+ public function threadTs(string $threadTs): self`
	`189`	`+ {`
	`190`	`+ $this->options['thread_ts'] = $threadTs;`
	`191`	`+`
	`192`	`+ return $this;`
	`193`	`+ }`
`184`	`194`	`}`
Original file line number	Diff line number	Diff line change
`@@ -70,6 +70,7 @@ public function toArraySimpleOptionsProvider(): iterable`
`70`	`70`	`yield [['unfurl_links' => true]];`
`71`	`71`	`yield [['unfurl_media' => true]];`
`72`	`72`	`yield [['username' => 'baz']];`
	`73`	`+ yield [['thread_ts' => '1503435956.000247']];`
`73`	`74`	`}`
`74`	`75`
`75`	`76`	`/**`
`@@ -111,6 +112,7 @@ public function setProvider(): iterable`
`111`	`112`	`yield ['unfurlLinks', 'unfurl_links', true];`
`112`	`113`	`yield ['unfurlMedia', 'unfurl_media', true];`
`113`	`114`	`yield ['username', 'username', 'baz'];`
	`115`	`+ yield ['threadTs', 'thread_ts', '1503435956.000247'];`
`114`	`116`	`}`
`115`	`117`
`116`	`118`	`public function testSetBlock()`