bug #23865 [Workflow] fixed InvalidDefinitionException message for StateMachineValidator (fmata)

lyrixx · lyrixx · commit eea78fdc78de · 2017-08-11T15:26:24.000+02:00
This PR was merged into the 3.3 branch. Discussion ---------- [Workflow] fixed InvalidDefinitionException message for StateMachineValidator | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Little mistake in the exception message which can be lead to difficult debugging if we don't pay attention in the workflow definition. Commits ------- 9c29f9c [Workflow] fixed InvalidDefinitionException message for StateMachineValidator
diff --git a/src/Symfony/Component/Workflow/Validator/StateMachineValidator.php b/src/Symfony/Component/Workflow/Validator/StateMachineValidator.php
@@ -31,7 +31,7 @@ public function validate(Definition $definition, $name)
             // Make sure that each transition has exactly one FROM
             $froms = $transition->getFroms();
             if (1 !== count($froms)) {
-                throw new InvalidDefinitionException(sprintf('A transition in StateMachine can only have one input. But the transition "%s" in StateMachine "%s" has %d inputs.', $transition->getName(), $name, count($transition->getTos())));
+                throw new InvalidDefinitionException(sprintf('A transition in StateMachine can only have one input. But the transition "%s" in StateMachine "%s" has %d inputs.', $transition->getName(), $name, count($froms)));
             }
 
             // Enforcing uniqueness of the names of transitions starting at each node

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public function validate(Definition $definition, $name)`
`31`	`31`	`// Make sure that each transition has exactly one FROM`
`32`	`32`	`$froms = $transition->getFroms();`
`33`	`33`	`if (1 !== count($froms)) {`
`34`		`- throw new InvalidDefinitionException(sprintf('A transition in StateMachine can only have one input. But the transition "%s" in StateMachine "%s" has %d inputs.', $transition->getName(), $name, count($transition->getTos())));`
	`34`	`+ throw new InvalidDefinitionException(sprintf('A transition in StateMachine can only have one input. But the transition "%s" in StateMachine "%s" has %d inputs.', $transition->getName(), $name, count($froms)));`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`// Enforcing uniqueness of the names of transitions starting at each node`