Removing provider option in more spots

weaverryan · weaverryan · commit eceb49090a71 · 2023-10-01T21:00:28.000-04:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md b/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
@@ -27,6 +27,7 @@ CHANGELOG
  * Add `array $tokenAttributes = []` optional parameter to `KernelBrowser::loginUser()`
  * Add support for relative URLs in BrowserKit's redirect assertion.
  * Change BrowserKitAssertionsTrait::getClient() to be protected
+ * Removed the `framework.asset_mapper.provider` config option.
 
 6.3
 ---
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd b/src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd
@@ -202,7 +202,6 @@
         <xsd:attribute name="importmap-path" type="xsd:string" />
         <xsd:attribute name="importmap-polyfill" type="xsd:string" />
         <xsd:attribute name="vendor-dir" type="xsd:string" />
-        <xsd:attribute name="provider" type="xsd:string" />
     </xsd:complexType>
 
     <xsd:complexType name="asset_mapper_path" mixed="true">
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php
@@ -134,7 +134,6 @@ public function testAssetMapperCanBeEnabled()
             'importmap_path' => '%kernel.project_dir%/importmap.php',
             'importmap_polyfill' => null,
             'vendor_dir' => '%kernel.project_dir%/assets/vendor',
-            'provider' => 'jsdelivr.esm',
             'importmap_script_attributes' => [],
         ];
 
@@ -671,7 +670,6 @@ protected static function getBundleDefaultConfig()
                 'importmap_path' => '%kernel.project_dir%/importmap.php',
                 'importmap_polyfill' => null,
                 'vendor_dir' => '%kernel.project_dir%/assets/vendor',
-                'provider' => 'jsdelivr.esm',
                 'importmap_script_attributes' => [],
             ],
             'cache' => [
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/asset_mapper.xml b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/asset_mapper.xml
@@ -17,7 +17,6 @@
             importmap-path="%kernel.project_dir%/importmap.php"
             importmap-polyfill="https://cdn.example.com/polyfill.js"
             vendor-dir="%kernel.project_dir%/assets/vendor"
-            provider="jspm"
         >
             <framework:path>assets/</framework:path>
             <framework:path namespace="my_namespace">assets2/</framework:path>
diff --git a/src/Symfony/Component/AssetMapper/CHANGELOG.md b/src/Symfony/Component/AssetMapper/CHANGELOG.md
@@ -7,6 +7,7 @@ CHANGELOG
  * Mark the component as non experimental
  * Add CSS support to the importmap
  * Add "entrypoints" concept to the importmap
+ * Always download packages locally instead of using a CDN
  * Allow relative path strings in the importmap
  * Add `PreAssetsCompileEvent` event when running `asset-map:compile`
  * Add support for importmap paths to use the Asset component (for subdirectories)

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@`
`17`	`17`	`importmap-path="%kernel.project_dir%/importmap.php"`
`18`	`18`	`importmap-polyfill="https://cdn.example.com/polyfill.js"`
`19`	`19`	`vendor-dir="%kernel.project_dir%/assets/vendor"`
`20`		`- provider="jspm"`
`21`	`20`	`>`
`22`	`21`	`<framework:path>assets/</framework:path>`
`23`	`22`	`<framework:path namespace="my_namespace">assets2/</framework:path>`