minor #33808 [Console] Throw a TypeError for non-int return value calling Command::execute() (jschaedl)

nicolas-grekas · nicolas-grekas · commit ebda9d1ae750 · 2019-10-02T19:22:46.000+02:00
This PR was merged into the 5.0-dev branch. Discussion ---------- [Console] Throw a TypeError for non-int return value calling Command::execute() | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no  | Deprecations? | yes  | Tickets | Fix #33747  | License | MIT | Doc PR | -  ### Todo - [x] needs to be rebased after 4.4 was merged into master (see: #33805) Commits ------- b3a3b0c [Console] Throw a TypeError for non-int return values on calling Command::execute()
diff --git a/src/Symfony/Component/Console/CHANGELOG.md b/src/Symfony/Component/Console/CHANGELOG.md
@@ -10,6 +10,7 @@ CHANGELOG
  * removed `TableStyle::getHorizontalBorderChar()` method in favor of `TableStyle::getBorderChars()`
  * removed `TableStyle::setVerticalBorderChar()` method in favor of `TableStyle::setVerticalBorderChars()`
  * removed `TableStyle::getVerticalBorderChar()` method in favor of `TableStyle::getBorderChars()`
+ * removed support for returning `null` from `Command::execute()`, return `0` instead
  * `ProcessHelper::run()` accepts only `array|Symfony\Component\Process\Process` for its `command` argument
  * `Application::setDispatcher` accepts only `Symfony\Contracts\EventDispatcher\EventDispatcherInterface` 
     for its `dispatcher` argument
diff --git a/src/Symfony/Component/Console/Command/Command.php b/src/Symfony/Component/Console/Command/Command.php
@@ -255,7 +255,7 @@ public function run(InputInterface $input, OutputInterface $output)
             $statusCode = $this->execute($input, $output);
 
             if (!\is_int($statusCode)) {
-                @trigger_error(sprintf('Return value of "%s::execute()" should always be of the type int since Symfony 4.4, %s returned.', \get_class($this), \gettype($statusCode)), E_USER_DEPRECATED);
+                throw new \TypeError(sprintf('Return value of "%s::execute()" must be of the type int, %s returned.', \get_class($this), \gettype($statusCode)));
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -255,7 +255,7 @@ public function run(InputInterface $input, OutputInterface $output)`
`255`	`255`	`$statusCode = $this->execute($input, $output);`
`256`	`256`
`257`	`257`	`if (!\is_int($statusCode)) {`
`258`		`- @trigger_error(sprintf('Return value of "%s::execute()" should always be of the type int since Symfony 4.4, %s returned.', \get_class($this), \gettype($statusCode)), E_USER_DEPRECATED);`
	`258`	`+ throw new \TypeError(sprintf('Return value of "%s::execute()" must be of the type int, %s returned.', \get_class($this), \gettype($statusCode)));`
`259`	`259`	`}`
`260`	`260`	`}`
`261`	`261`