bug #23983 [VarDumper] Strengthen dumped JS (nicolas-grekas)

fabpot · fabpot · commit ebd14ee67f39 · 2017-08-26T06:19:07.000-07:00
This PR was merged into the 3.3 branch. Discussion ---------- [VarDumper] Strengthen dumped JS | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - 3.3 part of #23982 Commits ------- 5e05fc9 [VarDumper] Strengthen dumped JS
diff --git a/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php b/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php
@@ -187,7 +187,7 @@ function toggle(a, recursive) {
 function collapse(a, recursive) {
     var s = a.nextSibling || {}, oldClass = s.className;
 
-    if ('sf-dump-expanded' == oldClass) {
+    if (/\bsf-dump-expanded\b/.test(oldClass)) {
         toggle(a, recursive);
 
         return true;
@@ -199,7 +199,7 @@ function collapse(a, recursive) {
 function expand(a, recursive) {
     var s = a.nextSibling || {}, oldClass = s.className;
 
-    if ('sf-dump-compact' == oldClass) {
+    if (/\bsf-dump-compact\b/.test(oldClass)) {
         toggle(a, recursive);
 
         return true;
@@ -254,8 +254,8 @@ function highlight(root, activeNode, nodes) {
 
 function resetHighlightedNodes(root) {
     Array.from(root.querySelectorAll('.sf-dump-str, .sf-dump-key, .sf-dump-public, .sf-dump-protected, .sf-dump-private')).forEach(function (strNode) {
-        strNode.className = strNode.className.replace(/\b sf-dump-highlight\b/, '');
-        strNode.className = strNode.className.replace(/\b sf-dump-highlight-active\b/, '');
+        strNode.className = strNode.className.replace(/\bsf-dump-highlight\b/, '');
+        strNode.className = strNode.className.replace(/\bsf-dump-highlight-active\b/, '');
     });
 }
 
@@ -352,7 +352,7 @@ function xpathString(str) {
         } else if (/\bsf-dump-str-toggle\b/.test(a.className)) {
             e.preventDefault();
             e = a.parentNode.parentNode;
-            e.className = e.className.replace(/sf-dump-str-(expand|collapse)/, a.parentNode.className);
+            e.className = e.className.replace(/\bsf-dump-str-(expand|collapse)\b/, a.parentNode.className);
         }
     });
 
@@ -518,8 +518,7 @@ function showCurrent(state)
         Array.from(search.querySelectorAll('.sf-dump-search-input-next, .sf-dump-search-input-previous')).forEach(function (btn) {
             addEventListener(btn, 'click', function (e) {
                 e.preventDefault();
-                var direction = -1 !== e.target.className.indexOf('next') ? 'next' : 'previous';
-                'next' === direction ? state.next() : state.previous();
+                -1 !== e.target.className.indexOf('next') ? state.next() : state.previous();
                 searchInput.focus();
                 collapseAll(root);
                 showCurrent(state);
