bug #48501 [RateLimiter] Add int to Reservation::wait() (DaRealFreak)

nicolas-grekas · nicolas-grekas · commit e8075032b78c · 2022-12-09T08:37:12.000+01:00
This PR was submitted for the 6.3 branch but it was merged into the 5.4 branch instead. Discussion ---------- [RateLimiter] Add `int` to `Reservation::wait()` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #48500 | License | MIT The `usleep` function accepts int as parameter type (https://www.php.net/manual/en/function.usleep.php), while the passed type is float in `Reservation::wait` (due to `Reservation::getWaitDuration` returning a float value for the 1e6 multiplication) To prevent deprecation notices we can typecast the float value to int before passing it to `usleep` Commits ------- 6ad3279 [RateLimiter] Add typecast to Reservation::wait
diff --git a/src/Symfony/Component/RateLimiter/Reservation.php b/src/Symfony/Component/RateLimiter/Reservation.php
@@ -45,6 +45,6 @@ public function getRateLimit(): RateLimit
 
     public function wait(): void
     {
-        usleep($this->getWaitDuration() * 1e6);
+        usleep((int) ($this->getWaitDuration() * 1e6));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,6 @@ public function getRateLimit(): RateLimit`
`45`	`45`
`46`	`46`	`public function wait(): void`
`47`	`47`	`{`
`48`		`- usleep($this->getWaitDuration() * 1e6);`
	`48`	`+ usleep((int) ($this->getWaitDuration() * 1e6));`
`49`	`49`	`}`
`50`	`50`	`}`