bug #33814 [HttpFoundation] Check if data passed to SessionBagProxy::initialize is an array (mynameisbogdan)

nicolas-grekas · nicolas-grekas · commit e7f70415a5f9 · 2019-10-02T18:15:28.000+02:00
This PR was submitted for the 4.3 branch but it was merged into the 3.4 branch instead (closes #33814). Discussion ---------- [HttpFoundation] Check if data passed to SessionBagProxy::initialize is an array [HttpFoundation] Check if data passed to SessionBagProxy::initialize is an array | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | Fix #33769  | License | MIT  If `$_SESSION['_sf2_attributes']` is set to a string, `SessionBagProxy::initialize` will throw an error since it's argument is type-hinted as array. So this change is to check before if the data to be passed is truly an array. Commits ------- 38782bc [HttpFoundation] Check if data passed to SessionBagProxy::initialize is an array
diff --git a/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php b/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php
@@ -430,7 +430,7 @@ protected function loadSession(array &$session = null)
 
         foreach ($bags as $bag) {
             $key = $bag->getStorageKey();
-            $session[$key] = isset($session[$key]) ? $session[$key] : [];
+            $session[$key] = isset($session[$key]) && \is_array($session[$key]) ? $session[$key] : [];
             $bag->initialize($session[$key]);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -430,7 +430,7 @@ protected function loadSession(array &$session = null)`
`430`	`430`
`431`	`431`	`foreach ($bags as $bag) {`
`432`	`432`	`$key = $bag->getStorageKey();`
`433`		`- $session[$key] = isset($session[$key]) ? $session[$key] : [];`
	`433`	`+ $session[$key] = isset($session[$key]) && \is_array($session[$key]) ? $session[$key] : [];`
`434`	`434`	`$bag->initialize($session[$key]);`
`435`	`435`	`}`
`436`	`436`