clear unchecked choice radio boxes even if clear missing is set to false

xabbuh · xabbuh · commit e7b4851ea04d · 2021-03-08T18:14:47.000+01:00
diff --git a/src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php b/src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php
@@ -141,6 +141,8 @@ public function buildForm(FormBuilderInterface $builder, array $options)
                             $knownValues[$child->getName()] = $value;
                             unset($unknownValues[$value]);
                             continue;
+                        } else {
+                            $knownValues[$child->getName()] = null;
                         }
                     }
                 } else {
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/ChoiceTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/ChoiceTypeTest.php
@@ -1287,6 +1287,20 @@ public function testSubmitSingleExpandedObjectChoices()
         $this->assertNull($form[4]->getViewData());
     }
 
+    public function testSubmitSingleExpandedClearMissingFalse()
+    {
+        $form = $this->factory->create(self::TESTED_TYPE, 'foo', [
+            'choices' => [
+                'foo label' => 'foo',
+                'bar label' => 'bar',
+            ],
+            'expanded' => true,
+        ]);
+        $form->submit('bar', false);
+
+        $this->assertSame('bar', $form->getData());
+    }
+
     public function testSubmitMultipleExpanded()
     {
         $form = $this->factory->create(static::TESTED_TYPE, null, [

Original file line number	Diff line number	Diff line change
`@@ -141,6 +141,8 @@ public function buildForm(FormBuilderInterface $builder, array $options)`
`141`	`141`	`$knownValues[$child->getName()] = $value;`
`142`	`142`	`unset($unknownValues[$value]);`
`143`	`143`	`continue;`
	`144`	`+ } else {`
	`145`	`+ $knownValues[$child->getName()] = null;`
`144`	`146`	`}`
`145`	`147`	`}`
`146`	`148`	`} else {`