bug #31936 PropertyInfoLoader should not try to add validation to non-existent property (weaverryan)

nicolas-grekas · nicolas-grekas · commit e7184588e7e8 · 2019-06-07T20:25:55.000+02:00
This PR was merged into the 4.3 branch. Discussion ---------- PropertyInfoLoader should not try to add validation to non-existent property | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31796 (see #31796 (comment)) | License | MIT | Doc PR | not needed With auto-validation, if a class has a setter (e.g. `setFoo()`) but there is no `foo` property, it still tries to add validation to that property, resulting in a: > Property "foo" does not exist in class "App\Entity\Bar This fixes that. I believe it's "just this simple", but I don't have any experience with the code in this area yet. Cheers! Commits ------- b702598 Fixing bug where PropertyInfoLoader tried to add validation to non-existent properties
diff --git a/src/Symfony/Component/Validator/Mapping/Loader/PropertyInfoLoader.php b/src/Symfony/Component/Validator/Mapping/Loader/PropertyInfoLoader.php
@@ -60,6 +60,10 @@ public function loadClassMetadata(ClassMetadata $metadata)
                 continue;
             }
 
+            if (!property_exists($className, $property)) {
+                continue;
+            }
+
             $types = $this->typeExtractor->getTypes($className, $property);
             if (null === $types) {
                 continue;
diff --git a/src/Symfony/Component/Validator/Tests/Fixtures/PropertyInfoLoaderEntity.php b/src/Symfony/Component/Validator/Tests/Fixtures/PropertyInfoLoaderEntity.php
@@ -48,4 +48,8 @@ class PropertyInfoLoaderEntity
     public $alreadyPartiallyMappedCollection;
 
     public $readOnly;
+
+    public function setNonExistentField()
+    {
+    }
 }
diff --git a/src/Symfony/Component/Validator/Tests/Mapping/Loader/PropertyInfoLoaderTest.php b/src/Symfony/Component/Validator/Tests/Mapping/Loader/PropertyInfoLoaderTest.php
@@ -46,6 +46,7 @@ public function testLoadClassMetadata()
                 'alreadyMappedNotBlank',
                 'alreadyPartiallyMappedCollection',
                 'readOnly',
+                'nonExistentField',
             ])
         ;
         $propertyInfoStub

Original file line number	Diff line number	Diff line change
`@@ -48,4 +48,8 @@ class PropertyInfoLoaderEntity`
`48`	`48`	`public $alreadyPartiallyMappedCollection;`
`49`	`49`
`50`	`50`	`public $readOnly;`
	`51`	`+`
	`52`	`+ public function setNonExistentField()`
	`53`	`+ {`
	`54`	`+ }`
`51`	`55`	`}`
Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,7 @@ public function testLoadClassMetadata()`
`46`	`46`	`'alreadyMappedNotBlank',`
`47`	`47`	`'alreadyPartiallyMappedCollection',`
`48`	`48`	`'readOnly',`
	`49`	`+ 'nonExistentField',`
`49`	`50`	`])`
`50`	`51`	`;`
`51`	`52`	`$propertyInfoStub`