feature #21106 [Validator] support DateTimeInterface instances for times (xabbuh)

fabpot · fabpot · commit e6cfa9a3579c · 2017-01-02T12:08:39.000-08:00
This PR was merged into the 3.3-dev branch. Discussion ---------- [Validator] support DateTimeInterface instances for times | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The same has already been done for the `Date` and `DateTime` constraints in #18759. Commits ------- 1fa9276 support DateTimeInterface instances for times
diff --git a/src/Symfony/Component/Validator/Constraints/TimeValidator.php b/src/Symfony/Component/Validator/Constraints/TimeValidator.php
@@ -47,7 +47,7 @@ public function validate($value, Constraint $constraint)
             throw new UnexpectedTypeException($constraint, __NAMESPACE__.'\Time');
         }
 
-        if (null === $value || '' === $value || $value instanceof \DateTime) {
+        if (null === $value || '' === $value || $value instanceof \DateTimeInterface) {
             return;
         }
 
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/TimeValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/TimeValidatorTest.php
@@ -99,4 +99,11 @@ public function getInvalidTimes()
             array('00:00:60', Time::INVALID_TIME_ERROR),
         );
     }
+
+    public function testDateTimeImmutableIsValid()
+    {
+        $this->validator->validate(new \DateTimeImmutable(), new Time());
+
+        $this->assertNoViolation();
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public function validate($value, Constraint $constraint)`
`47`	`47`	`throw new UnexpectedTypeException($constraint, __NAMESPACE__.'\Time');`
`48`	`48`	`}`
`49`	`49`
`50`		`- if (null === $value \|\| '' === $value \|\| $value instanceof \DateTime) {`
	`50`	`+ if (null === $value \|\| '' === $value \|\| $value instanceof \DateTimeInterface) {`
`51`	`51`	`return;`
`52`	`52`	`}`
`53`	`53`
Original file line number	Diff line number	Diff line change
`@@ -99,4 +99,11 @@ public function getInvalidTimes()`
`99`	`99`	`array('00:00:60', Time::INVALID_TIME_ERROR),`
`100`	`100`	`);`
`101`	`101`	`}`
	`102`	`+`
	`103`	`+ public function testDateTimeImmutableIsValid()`
	`104`	`+ {`
	`105`	`+ $this->validator->validate(new \DateTimeImmutable(), new Time());`
	`106`	`+`
	`107`	`+ $this->assertNoViolation();`
	`108`	`+ }`
`102`	`109`	`}`