minor #41596 [FrameworkBundle] Remove duplicate catch block (OskarStark)

nicolas-grekas · nicolas-grekas · commit e658d001e770 · 2021-06-08T10:55:51.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Remove duplicate catch block | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #...  | License | MIT | Doc PR | symfony/symfony-docs#...  Spottet while reviewing #41576 by `@derrabus` Commits ------- 32cac1c Remove duplicate catch block
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/CachePoolsTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/CachePoolsTest.php
@@ -39,11 +39,6 @@ public function testRedisCachePools()
                 throw $e;
             }
             $this->markTestSkipped($e->getMessage());
-        } catch (\PHPUnit\Framework\Error\Warning $e) {
-            if (0 !== strpos($e->getMessage(), 'unable to connect to')) {
-                throw $e;
-            }
-            $this->markTestSkipped($e->getMessage());
         } catch (InvalidArgumentException $e) {
             if (0 !== strpos($e->getMessage(), 'Redis connection ')) {
                 throw $e;
@@ -67,11 +62,6 @@ public function testRedisCustomCachePools()
                 throw $e;
             }
             $this->markTestSkipped($e->getMessage());
-        } catch (\PHPUnit\Framework\Error\Warning $e) {
-            if (0 !== strpos($e->getMessage(), 'unable to connect to')) {
-                throw $e;
-            }
-            $this->markTestSkipped($e->getMessage());
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -39,11 +39,6 @@ public function testRedisCachePools()`
`39`	`39`	`throw $e;`
`40`	`40`	`}`
`41`	`41`	`$this->markTestSkipped($e->getMessage());`
`42`		`- } catch (\PHPUnit\Framework\Error\Warning $e) {`
`43`		`- if (0 !== strpos($e->getMessage(), 'unable to connect to')) {`
`44`		`- throw $e;`
`45`		`- }`
`46`		`- $this->markTestSkipped($e->getMessage());`
`47`	`42`	`} catch (InvalidArgumentException $e) {`
`48`	`43`	`if (0 !== strpos($e->getMessage(), 'Redis connection ')) {`
`49`	`44`	`throw $e;`
`@@ -67,11 +62,6 @@ public function testRedisCustomCachePools()`
`67`	`62`	`throw $e;`
`68`	`63`	`}`
`69`	`64`	`$this->markTestSkipped($e->getMessage());`
`70`		`- } catch (\PHPUnit\Framework\Error\Warning $e) {`
`71`		`- if (0 !== strpos($e->getMessage(), 'unable to connect to')) {`
`72`		`- throw $e;`
`73`		`- }`
`74`		`- $this->markTestSkipped($e->getMessage());`
`75`	`65`	`}`
`76`	`66`	`}`
`77`	`67`