bug #32011 [HttpClient] fix closing debug stream prematurely (nicolas-grekas)

fabpot · fabpot · commit e63577500cc2 · 2019-06-13T11:48:41.000+02:00
This PR was merged into the 4.3 branch. Discussion ---------- [HttpClient] fix closing debug stream prematurely | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31985 | License | MIT | Doc PR | - @ElGecko76 can you please confirm this fixes the issue for you? I'm not able to reproduce so I can't myself. Thanks. Commits ------- 21857a1 [HttpClient] fix closing debug stream prematurely
diff --git a/src/Symfony/Component/HttpClient/Response/CurlResponse.php b/src/Symfony/Component/HttpClient/Response/CurlResponse.php
@@ -168,8 +168,8 @@ public function getInfo(string $type = null)
                 rewind($this->debugBuffer);
                 $info['debug'] = stream_get_contents($this->debugBuffer);
                 curl_setopt($this->handle, CURLOPT_VERBOSE, false);
-                fclose($this->debugBuffer);
-                $this->debugBuffer = null;
+                rewind($this->debugBuffer);
+                ftruncate($this->debugBuffer, 0);
                 $this->finalInfo = $info;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -168,8 +168,8 @@ public function getInfo(string $type = null)`
`168`	`168`	`rewind($this->debugBuffer);`
`169`	`169`	`$info['debug'] = stream_get_contents($this->debugBuffer);`
`170`	`170`	`curl_setopt($this->handle, CURLOPT_VERBOSE, false);`
`171`		`- fclose($this->debugBuffer);`
`172`		`- $this->debugBuffer = null;`
	`171`	`+ rewind($this->debugBuffer);`
	`172`	`+ ftruncate($this->debugBuffer, 0);`
`173`	`173`	`$this->finalInfo = $info;`
`174`	`174`	`}`
`175`	`175`	`}`