Username and password in basic auth are allowed to contain '.'

rquadling · rquadling · commit e5d57dd0500e · 2017-10-17T13:03:20.000+01:00
Initially reported by Fede Isas in beberlei/assert#234
diff --git a/src/Symfony/Component/Validator/Constraints/UrlValidator.php b/src/Symfony/Component/Validator/Constraints/UrlValidator.php
@@ -24,7 +24,7 @@ class UrlValidator extends ConstraintValidator
 {
     const PATTERN = '~^
             (%s)://                                 # protocol
-            (([\pL\pN-]+:)?([\pL\pN-]+)@)?          # basic auth
+            (([\.\pL\pN-]+:)?([\.\pL\pN-]+)@)?      # basic auth
             (
                 ([\pL\pN\pS-\.])+(\.?([\pL]|xn\-\-[\pL\pN-]+)+\.?) # a domain name
                     |                                              # or
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/UrlValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/UrlValidatorTest.php
@@ -103,6 +103,9 @@ public function getValidUrls()
             array('http://xn--d1abbgf6aiiy.xn--p1ai/'),
             array('http://☎.com/'),
             array('http://username:password@symfony.com'),
+            array('http://user.name:password@symfony.com'),
+            array('http://username:pass.word@symfony.com'),
+            array('http://user.name:pass.word@symfony.com'),
             array('http://user-name@symfony.com'),
         );
     }

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ class UrlValidator extends ConstraintValidator`
`24`	`24`	`{`
`25`	`25`	`const PATTERN = '~^`
`26`	`26`	`(%s):// # protocol`
`27`		`- (([\pL\pN-]+:)?([\pL\pN-]+)@)? # basic auth`
	`27`	`+ (([\.\pL\pN-]+:)?([\.\pL\pN-]+)@)? # basic auth`
`28`	`28`	`(`
`29`	`29`	`([\pL\pN\pS-\.])+(\.?([\pL]\|xn\-\-[\pL\pN-]+)+\.?) # a domain name`
`30`	`30`	`\| # or`