Don't call blindly the redis client

jderusse · jderusse · commit e4db018b6d27 · 2017-03-22T22:50:35.000+01:00
diff --git a/src/Symfony/Component/Lock/Store/RedisStore.php b/src/Symfony/Component/Lock/Store/RedisStore.php
@@ -130,8 +130,11 @@ private function evaluate($script, $resource, array $args)
             return $this->redis->_instance($this->redis->_target($resource))->eval($script, array_merge(array($resource), $args), 1);
         }
 
-        // Have to be a \Predis\Client
-        return call_user_func_array(array($this->redis, 'eval'), array_merge(array($script, 1, $resource), $args));
+        if ($this->redis instanceof \Predis\Client) {
+            return call_user_func_array(array($this->redis, 'eval'), array_merge(array($script, 1, $resource), $args));
+        }
+
+        throw new InvalidArgumentException(sprintf('%s() expects been initialized with a Redis, RedisArray, RedisCluster or Predis\Client, %s given', __METHOD__, is_object($this->redis) ? get_class($this->redis) : gettype($this->redis)));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -130,8 +130,11 @@ private function evaluate($script, $resource, array $args)`
`130`	`130`	`return $this->redis->_instance($this->redis->_target($resource))->eval($script, array_merge(array($resource), $args), 1);`
`131`	`131`	`}`
`132`	`132`
`133`		`- // Have to be a \Predis\Client`
`134`		`- return call_user_func_array(array($this->redis, 'eval'), array_merge(array($script, 1, $resource), $args));`
	`133`	`+ if ($this->redis instanceof \Predis\Client) {`
	`134`	`+ return call_user_func_array(array($this->redis, 'eval'), array_merge(array($script, 1, $resource), $args));`
	`135`	`+ }`
	`136`	`+`
	`137`	`+ throw new InvalidArgumentException(sprintf('%s() expects been initialized with a Redis, RedisArray, RedisCluster or Predis\Client, %s given', __METHOD__, is_object($this->redis) ? get_class($this->redis) : gettype($this->redis)));`
`135`	`138`	`}`
`136`	`139`
`137`	`140`	`/**`