bug #9214 [FramworkBundle] Check event listener services are not abstract (lyrixx)

fabpot · fabpot · commit e410b1f311a0 · 2013-10-04T16:07:27.000+02:00
This PR was merged into the 2.2 branch. Discussion ---------- [FramworkBundle] Check event listener services are not abstract | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 6744ead [FramworkBundle][HttpKernel] Check event listener services are not abstract
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/RegisterKernelListenersPass.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/RegisterKernelListenersPass.php
@@ -30,6 +30,10 @@ public function process(ContainerBuilder $container)
                 throw new \InvalidArgumentException(sprintf('The service "%s" must be public as event listeners are lazy-loaded.', $id));
             }
 
+            if ($def->isAbstract()) {
+                throw new \InvalidArgumentException(sprintf('The service "%s" must not be abstract as event listeners are lazy-loaded.', $id));
+            }
+
             foreach ($events as $event) {
                 $priority = isset($event['priority']) ? $event['priority'] : 0;
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/RegisterKernelListenersPassTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/RegisterKernelListenersPassTest.php
@@ -115,6 +115,20 @@ public function testPrivateEventSubscriber()
         $registerListenersPass = new RegisterKernelListenersPass();
         $registerListenersPass->process($container);
     }
+
+    /**
+     * @expectedException \InvalidArgumentException
+     * @expectedExceptionMessage The service "foo" must not be abstract as event listeners are lazy-loaded.
+     */
+    public function testAbstractEventListener()
+    {
+        $container = new ContainerBuilder();
+        $container->register('foo', 'stdClass')->setAbstract(true)->addTag('kernel.event_listener', array());
+        $container->register('event_dispatcher', 'stdClass');
+
+        $registerListenersPass = new RegisterKernelListenersPass();
+        $registerListenersPass->process($container);
+    }
 }
 
 class SubscriberService implements \Symfony\Component\EventDispatcher\EventSubscriberInterface

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,10 @@ public function process(ContainerBuilder $container)`
`30`	`30`	`throw new \InvalidArgumentException(sprintf('The service "%s" must be public as event listeners are lazy-loaded.', $id));`
`31`	`31`	`}`
`32`	`32`
	`33`	`+ if ($def->isAbstract()) {`
	`34`	`+ throw new \InvalidArgumentException(sprintf('The service "%s" must not be abstract as event listeners are lazy-loaded.', $id));`
	`35`	`+ }`
	`36`	`+`
`33`	`37`	`foreach ($events as $event) {`
`34`	`38`	`$priority = isset($event['priority']) ? $event['priority'] : 0;`
`35`	`39`