8000 bug #53418 [FrameworkBundle][Notifier] Fix service registration (Mess… · symfony/symfony@e3d9fd2 · GitHub
[go: up one dir, main page]
Skip to content

Commit e3d9fd2

Browse files
nicolas-grekasnicolas-grekas
committed
bug #53418 [FrameworkBundle][Notifier] Fix service registration (MessageBird + TurboSms) (smnandre)
This PR was merged into the 5.4 branch. Discussion ---------- [FrameworkBundle][Notifier] Fix service registration (MessageBird + TurboSms) | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix # | License | MIT Inside the [registerNotifierConfiguration](https://github.com/symfony/symfony/blob/9069d14de61d6d54ba62a6b611430dd5f9cadc78/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L2486) method, the [$classToServices](https://github.com/symfony/symfony/blob/9069d14de61d6d54ba62a6b611430dd5f9cadc78/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L2537) map (TransportFactoryClass => serviceId) used the Transport class (instead of the TransportFactory) for MessageBird and TurboSms. The services are registered in [Ressources/config/notifier_transports.php](https://github.com/symfony/symfony/blob/9069d14de61d6d54ba62a6b611430dd5f9cadc78/src/Symfony/Bundle/FrameworkBundle/Resources/config/notifier_transports.php#L261) (with the correct Factory classes). This map is then used in this loop: ```php foreach ($classToServices as $class => $service) { $package = substr($service, \strlen('notifier.transport_factory.')); if (!ContainerBuilder::willBeAvailable(sprintf('symfony/%s-notifier', $package), $class, $parentPackages, true)) { $container->removeDefinition($service); $container->removeAlias(str_replace('-', '', $service)); // `@deprecated` to be removed in 6.0 } } ``` So i'm not sure it's considered a bug as IRL checking the Factory class or the Transport class did not make any difference as i read it.... but it's worth a fix for the future :) So i target 5.4 with no certitude :) Commits ------- 3e535b4 [Notifier] Fix FrameworkExtension factory classes (MessageBird & TurboSms)
2 parents 6010db4 + 3e535b4 commit e3d9fd2

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@
138138
use Symfony\Component\Notifier\Bridge\Mailjet\MailjetTransportFactory as MailjetNotifierTransportFactory;
139139
use Symfony\Component\Notifier\Bridge\Mattermost\MattermostTransportFactory;
140140
use Symfony\Component\Notifier\Bridge\Mercure\MercureTransportFactory;
141-
use Symfony\Component\Notifier\Bridge\MessageBird\MessageBirdTransport;
141+
use Symfony\Component\Notifier\Bridge\MessageBird\MessageBirdTransportFactory;
142142
use Symfony\Component\Notifier\Bridge\MessageMedia\MessageMediaTransportFactory;
143143
use Symfony\Component\Notifier\Bridge\MicrosoftTeams\MicrosoftTeamsTransportFactory;
144144
use Symfony\Component\Notifier\Bridge\Mobyt\MobytTransportFactory;
@@ -157,7 +157,7 @@
157157
use Symfony\Component\Notifier\Bridge\SpotHit\SpotHitTransportFactory;
158158
use Symfony\Component\Notifier\Bridge\Telegram\TelegramTransportFactory;
159159
use Symfony\Component\Notifier\Bridge\Telnyx\TelnyxTransportFactory;
160-
use Symfony\Component\Notifier\Bridge\TurboSms\TurboSmsTransport;
160+
use Symfony\Component\Notifier\Bridge\TurboSms\TurboSmsTransportFactory;
161161
use Symfony\Component\Notifier\Bridge\Twilio\TwilioTransportFactory;
162162
use Symfony\Component\Notifier\Bridge\Vonage\VonageTransportFactory;
163163
use Symfony\Component\Notifier\Bridge\Yunpian\YunpianTransportFactory;
@@ -2555,7 +2555,7 @@ private function registerNotifierConfiguration(array $config, ContainerBuilder $
25552555
MailjetNotifierTransportFactory::class => 'notifier.transport_factory.mailjet',
25562556
MattermostTransportFactory::class => 'notifier.transport_factory.mattermost',
25572557
MercureTransportFactory::class => 'notifier.transport_factory.mercure',
2558-
MessageBirdTransport::class => 'notifier.transport_factory.message-bird',
2558+
MessageBirdTransportFactory::class => 'notifier.transport_factory.message-bird',
25592559
MessageMediaTransportFactory::class => 'notifier.transport_factory.message-media',
25602560
MicrosoftTeamsTransportFactory::class => 'notifier.transport_factory.microsoft-teams',
25612561
MobytTransportFactory::class => 'notifier.transport_factory.mobyt',
@@ -2574,7 +2574,7 @@ private function registerNotifierConfiguration(array $config, ContainerBuilder $
25742574
SpotHitTransportFactory::class => 'notifier.transport_factory.spot-hit',
25752575
TelegramTransportFactory::class => 'notifier.transport_factory.telegram',
25762576
TelnyxTransportFactory::class => 'notifier.transport_factory.telnyx',
2577-
TurboSmsTransport::class => 'notifier.transport_factory.turbo-sms',
2577+
TurboSmsTransportFactory::class => 'notifier.transport_factory.turbo-sms',
25782578
TwilioTransportFactory::class => 'notifier.transport_factory.twilio',
25792579
VonageTransportFactory::class => 'notifier.transport_factory.vonage',
25802580
YunpianTransportFactory::class => 'notifier.transport_factory.yunpian',

0 commit comments

Comments
 (0)
0