[Assets] Allows empty base url for dev

GromNaN · fabpot · commit e3ac4694a667 · 2021-12-11T16:18:04.000+01:00
diff --git a/src/Symfony/Component/Asset/CHANGELOG.md b/src/Symfony/Component/Asset/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+6.1
+---
+
+* `UrlPackage` accepts empty strings as `base_url`, in order to simplify local dev configuration.
+
 6.0
 ---
 
diff --git a/src/Symfony/Component/Asset/Tests/UrlPackageTest.php b/src/Symfony/Component/Asset/Tests/UrlPackageTest.php
@@ -85,6 +85,7 @@ public function getContextConfigs()
 
             [true, ['http://example.com'], '', 'foo', 'http://example.com/foo?v1'],
             [true, ['http://example.com', 'https://example.com'], '', 'foo', 'https://example.com/foo?v1'],
+            [true, ['', 'https://example.com'], '', 'foo', '/foo?v1'],
         ];
     }
 
diff --git a/src/Symfony/Component/Asset/UrlPackage.php b/src/Symfony/Component/Asset/UrlPackage.php
@@ -117,7 +117,7 @@ private function getSslUrls(array $urls)
     {
         $sslUrls = [];
         foreach ($urls as $url) {
-            if (str_starts_with($url, 'https://') || str_starts_with($url, '//')) {
+            if (str_starts_with($url, 'https://') || str_starts_with($url, '//') || '' === $url) {
                 $sslUrls[] = $url;
             } elseif (null === parse_url($url, \PHP_URL_SCHEME)) {
                 throw new InvalidArgumentException(sprintf('"%s" is not a valid URL.', $url));

Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,7 @@ public function getContextConfigs()`
`85`	`85`
`86`	`86`	`[true, ['http://example.com'], '', 'foo', 'http://example.com/foo?v1'],`
`87`	`87`	`[true, ['http://example.com', 'https://example.com'], '', 'foo', 'https://example.com/foo?v1'],`
	`88`	`+ [true, ['', 'https://example.com'], '', 'foo', '/foo?v1'],`
`88`	`89`	`];`
`89`	`90`	`}`
`90`	`91`
Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ private function getSslUrls(array $urls)`
`117`	`117`	`{`
`118`	`118`	`$sslUrls = [];`
`119`	`119`	`foreach ($urls as $url) {`
`120`		`- if (str_starts_with($url, 'https://') \|\| str_starts_with($url, '//')) {`
	`120`	`+ if (str_starts_with($url, 'https://') \|\| str_starts_with($url, '//') \|\| '' === $url) {`
`121`	`121`	`$sslUrls[] = $url;`
`122`	`122`	`} elseif (null === parse_url($url, \PHP_URL_SCHEME)) {`
`123`	`123`	`throw new InvalidArgumentException(sprintf('"%s" is not a valid URL.', $url));`