chore: add @noniagriconomie code review

qkdreyer · noniagriconomie · qkdreyer · commit e3a3afebf5c2 · 2020-07-06T13:25:46.000+02:00
Co-authored-by: Antoine Makdessi &lt;antoine.makdessi@agriconomie.com&gt;
diff --git a/src/Symfony/Component/Messenger/Stamp/RedeliveryStamp.php b/src/Symfony/Component/Messenger/Stamp/RedeliveryStamp.php
@@ -24,12 +24,12 @@ final class RedeliveryStamp implements StampInterface
     private $exceptionMessage;
     private $flattenException;
 
-    public function __construct(int $retryCount, string $exceptionMessage = null, FlattenException $flattenException = null, \DateTimeTimmutable $redeliveredAt = null)
+    public function __construct(int $retryCount, string $exceptionMessage = null, FlattenException $flattenException = null, \DateTimeImmutable $redeliveredAt = null)
     {
         $this->retryCount = $retryCount;
         $this->exceptionMessage = $exceptionMessage;
         $this->flattenException = $flattenException;
-        $this->redeliveredAt = $redeliveredAt instanceof \DateTimeImmutable ? $redeliveredAt : new \DateTimeImmutable();
+        $this->redeliveredAt = $redeliveredAt ?? new \DateTimeImmutable();
     }
 
     public static function getRetryCountFromEnvelope(Envelope $envelope): int

Original file line number	Diff line number	Diff line change
`@@ -24,12 +24,12 @@ final class RedeliveryStamp implements StampInterface`
`24`	`24`	`private $exceptionMessage;`
`25`	`25`	`private $flattenException;`
`26`	`26`
`27`		`- public function __construct(int $retryCount, string $exceptionMessage = null, FlattenException $flattenException = null, \DateTimeTimmutable $redeliveredAt = null)`
	`27`	`+ public function __construct(int $retryCount, string $exceptionMessage = null, FlattenException $flattenException = null, \DateTimeImmutable $redeliveredAt = null)`
`28`	`28`	`{`
`29`	`29`	`$this->retryCount = $retryCount;`
`30`	`30`	`$this->exceptionMessage = $exceptionMessage;`
`31`	`31`	`$this->flattenException = $flattenException;`
`32`		`- $this->redeliveredAt = $redeliveredAt instanceof \DateTimeImmutable ? $redeliveredAt : new \DateTimeImmutable();`
	`32`	`+ $this->redeliveredAt = $redeliveredAt ?? new \DateTimeImmutable();`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`public static function getRetryCountFromEnvelope(Envelope $envelope): int`