bug #34011 [String] Add AbstractString::toString() method (simPod)

nicolas-grekas · nicolas-grekas · commit e28bc7841677 · 2019-10-18T13:19:07.000+02:00
This PR was merged into the 5.0-dev branch. Discussion ---------- [String] Add AbstractString::toString() method | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Deprecations? | no | License | MIT Adds a way to use String in an objective way, without typecasting -> calling magical `__toString()`. Before ```php $value = (string) (new UnicodeString('foobar')) ->repeat(2) ->lower(); ``` After also possible ```php $value = (new UnicodeString('foobar')) ->repeat(2) ->lower() ->toString(); ``` Commits ------- 5540bc7 Add toString() method for String
diff --git a/src/Symfony/Component/String/AbstractString.php b/src/Symfony/Component/String/AbstractString.php
@@ -589,6 +589,11 @@ public function toCodePointString(): CodePointString
         return new CodePointString($this->string);
     }
 
+    public function toString(): string
+    {
+        return $this->string;
+    }
+
     public function toUnicodeString(): UnicodeString
     {
         return new UnicodeString($this->string);
diff --git a/src/Symfony/Component/String/Tests/AbstractAsciiTestCase.php b/src/Symfony/Component/String/Tests/AbstractAsciiTestCase.php
@@ -1370,4 +1370,11 @@ public static function provideTruncate()
             ['fo...', 'foobar', 5, '...'],
         ];
     }
+
+    public function testToString()
+    {
+        $instance = static::createFromString('foobar');
+
+        self::assertSame('foobar', $instance->toString());
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -589,6 +589,11 @@ public function toCodePointString(): CodePointString`
`589`	`589`	`return new CodePointString($this->string);`
`590`	`590`	`}`
`591`	`591`
	`592`	`+ public function toString(): string`
	`593`	`+ {`
	`594`	`+ return $this->string;`
	`595`	`+ }`
	`596`	`+`
`592`	`597`	`public function toUnicodeString(): UnicodeString`
`593`	`598`	`{`
`594`	`599`	`return new UnicodeString($this->string);`
Original file line number	Diff line number	Diff line change
`@@ -1370,4 +1370,11 @@ public static function provideTruncate()`
`1370`	`1370`	`['fo...', 'foobar', 5, '...'],`
`1371`	`1371`	`];`
`1372`	`1372`	`}`
	`1373`	`+`
	`1374`	`+ public function testToString()`
	`1375`	`+ {`
	`1376`	`+ $instance = static::createFromString('foobar');`
	`1377`	`+`
	`1378`	`+ self::assertSame('foobar', $instance->toString());`
	`1379`	`+ }`
`1373`	`1380`	`}`