bug #21200 [Filesystem] Check that directory is writable after created it in dumpFile() (chalasr)

fabpot · fabpot · commit e18f47f8d5f1 · 2017-01-08T07:59:38.000-08:00
This PR was merged into the 2.7 branch. Discussion ---------- [Filesystem] Check that directory is writable after created it in dumpFile() | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20612 (comment) | License | MIT | Doc PR | n/a In case permissions have been changed meanwhile Commits ------- dbc4148 [Filesystem] Check that the directory is writable after created it in dumpFile()
diff --git a/src/Symfony/Component/Filesystem/Filesystem.php b/src/Symfony/Component/Filesystem/Filesystem.php
@@ -498,7 +498,9 @@ public function dumpFile($filename, $content, $mode = 0666)
 
         if (!is_dir($dir)) {
             $this->mkdir($dir);
-        } elseif (!is_writable($dir)) {
+        }
+
+        if (!is_writable($dir)) {
             throw new IOException(sprintf('Unable to write to the "%s" directory.', $dir), 0, null, $dir);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -498,7 +498,9 @@ public function dumpFile($filename, $content, $mode = 0666)`
`498`	`498`
`499`	`499`	`if (!is_dir($dir)) {`
`500`	`500`	`$this->mkdir($dir);`
`501`		`- } elseif (!is_writable($dir)) {`
	`501`	`+ }`
	`502`	`+`
	`503`	`+ if (!is_writable($dir)) {`
`502`	`504`	`throw new IOException(sprintf('Unable to write to the "%s" directory.', $dir), 0, null, $dir);`
`503`	`505`	`}`
`504`	`506`