[Yaml] deprecate parsing mappings without keys

xabbuh · xabbuh · commit e0ea9892df29 · 2017-02-17T12:35:21.000+01:00
diff --git a/src/Symfony/Component/Yaml/Inline.php b/src/Symfony/Component/Yaml/Inline.php
@@ -482,7 +482,7 @@ private static function parseMapping($mapping, $flags, &$i = 0, $references = ar
             }
 
             if (':' === $key) {
-                throw new ParseException('A mapping without a key is invalid.');
+                @trigger_error('Omitting the key of a mapping is deprecated and will throw a ParseException in 4.0.', E_USER_DEPRECATED);
             }
 
             if (':' !== $key && (!isset($mapping[$i + 1]) || !in_array($mapping[$i + 1], array(' ', ',', '[', ']', '{', '}'), true))) {
diff --git a/src/Symfony/Component/Yaml/Tests/InlineTest.php b/src/Symfony/Component/Yaml/Tests/InlineTest.php
@@ -703,7 +703,6 @@ public function testTheEmptyStringIsAValidMappingKey()
      */
     public function testMappingKeysCannotBeOmitted()
     {
-        Inline::parse('{: foo}');
         $this->assertSame(array(':' => 'foo'), Inline::parse('{: foo}'));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -482,7 +482,7 @@ private static function parseMapping($mapping, $flags, &$i = 0, $references = ar`
`482`	`482`	`}`
`483`	`483`
`484`	`484`	`if (':' === $key) {`
`485`		`- throw new ParseException('A mapping without a key is invalid.');`
	`485`	`+ @trigger_error('Omitting the key of a mapping is deprecated and will throw a ParseException in 4.0.', E_USER_DEPRECATED);`
`486`	`486`	`}`
`487`	`487`
`488`	`488`	`if (':' !== $key && (!isset($mapping[$i + 1]) \|\| !in_array($mapping[$i + 1], array(' ', ',', '[', ']', '{', '}'), true))) {`
Original file line number	Diff line number	Diff line change
`@@ -703,7 +703,6 @@ public function testTheEmptyStringIsAValidMappingKey()`
`703`	`703`	`*/`
`704`	`704`	`public function testMappingKeysCannotBeOmitted()`
`705`	`705`	`{`
`706`		`- Inline::parse('{: foo}');`
`707`	`706`	`$this->assertSame(array(':' => 'foo'), Inline::parse('{: foo}'));`
`708`	`707`	`}`
`709`	`708`	`}`