8000 minor #49431 [Mailer][Translation] Remove some `static` occurrences t… · symfony/symfony@dee9e76 · GitHub
[go: up one dir, main page]
Skip to content

Commit dee9e76

Browse files
nicolas-grekasnicolas-grekas
committed
minor #49431 [Mailer][Translation] Remove some static occurrences that may cause unstable tests (alexandre-daubois)
This PR was merged into the 6.3 branch. Discussion ---------- [Mailer][Translation] Remove some `static` occurrences that may cause unstable tests | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | _NA_ | License | MIT | Doc PR | _NA_ I had a little tchat with `@nicolas`-grekas who warned me that a few of my late edits on static data providers are a bit dangerous. Indeed, some helper methods were using static properties, which could lead to some leaks between test cases, and/or unstable tests. Helper classes doing so, found in `Translation` and `Mailer`, have been reverted to non-static ones. Data-providers are of course still statics and have been adapted to not use those methods. The targeted branch is 6.3 and this is intended, as requested by Nicolas. If you need any help during the backport of these edits, I'll be happy to help again! ℹ️ A lot of notifier bridges has been introduced in 6.3 and their data providers weren't updated. I also bundled this change in the PR, which should fix 6.3 pipeline as well. Finally, I updated `SmsapiTransportFactoryTest::missingRequiredOptionProvider`. As the `from` option has been made optional, the only dataset provided failed. Commits ------- 2ca9cf8 [Mailer][Translation][Notifier] Remove some `static` occurrences that may cause unstable tests
1 parent 6627291 commit dee9e76

File tree

18 files changed

+263
-258
lines changed

18 files changed

+263
-258
lines changed

‎src/Symfony/Component/Mailer/Bridge/Amazon/Tests/Transport/SesTransportFactoryTest.php

Lines changed: 24 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313

1414
use AsyncAws\Core\Configuration;
1515
use AsyncAws\Ses\SesClient;
16+
use Psr\Log\NullLogger;
17+
use Symfony\Component\HttpClient\MockHttpClient;
1618
use Symfony\Component\Mailer\Bridge\Amazon\Transport\SesApiAsyncAwsTransport;
1719
use Symfony\Component\Mailer\Bridge\Amazon\Transport\SesHttpAsyncAwsTransport;
1820
use Symfony\Component\Mailer\Bridge\Amazon\Transport\SesSmtpTransport;
@@ -23,9 +25,9 @@
2325

2426
class SesTransportFactoryTest extends TransportFactoryTestCase
2527
{
26-
public static function getFactory(): TransportFactoryInterface
28+
public function getFactory(): TransportFactoryInterface
2729
{
28-
return new SesTransportFactory(self::getDispatcher(), self::getClient(), self::getLogger());
30+
return new SesTransportFactory(null, new MockHttpClient(), new NullLogger());
2931
}
3032

3133
public static function supportsProvider(): iterable
@@ -63,98 +65,97 @@ public static function supportsProvider(): iterable
6365

6466
public static function createProvider(): iterable
6567
{
66-
$client = self::getClient();
67-
$dispatcher = self::getDispatcher();
68-
$logger = self::getLogger();
68+
$client = new MockHttpClient();
69+
$logger = new NullLogger();
6970

7071
yield [
7172
new Dsn('ses+api', 'default', self::USER, self::PASSWORD),
72-
new SesApiAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1']), null, $client, $logger), $dispatcher, $logger),
73+
new SesApiAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1']), null, $client, $logger), null, $logger),
7374
];
7475

7576
yield [
7677
new Dsn('ses+api', 'default', self::USER, self::PASSWORD, null, ['region' => 'eu-west-2']),
77-
new SesApiAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-2']), null, $client, $logger), $dispatcher, $logger),
78+
new SesApiAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-2']), null, $client, $logger), null, $logger),
7879
];
7980

8081
yield [
8182
new Dsn('ses+api', 'example.com', self::USER, self::PASSWORD, 8080),
82-
new SesApiAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1', 'endpoint' => 'https://example.com:8080']), null, $client, $logger), $dispatcher, $logger),
83+
new SesApiAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1', 'endpoint' => 'https://example.com:8080']), null, $client, $logger), null, $logger),
8384
];
8485

8586
yield [
8687
new Dsn('ses+api', 'default', self::USER, self::PASSWORD, null, ['session_token' => 'se$sion']),
87-
new SesApiAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1', 'sessionToken' => 'se$sion']), null, $client, $logger), $dispatcher, $logger),
88+
new SesApiAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1', 'sessionToken' => 'se$sion']), null, $client, $logger), null, $logger),
8889
];
8990

9091
yield [
9192
new Dsn('ses+api', 'default', self::USER, self::PASSWORD, null, ['region' => 'eu-west-2', 'session_token' => 'se$sion']),
92-
new SesApiAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-2', 'sessionToken' => 'se$sion']), null, $client, $logger), $dispatcher, $logger),
93+
new SesApiAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-2', 'sessionToken' => 'se$sion']), null, $client, $logger), null, $logger),
9394
];
9495

9596
yield [
9697
new Dsn('ses+api', 'example.com', self::USER, self::PASSWORD, 8080, ['session_token' => 'se$sion']),
97-
new SesApiAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1', 'endpoint' => 'https://example.com:8080', 'sessionToken' => 'se$sion']), null, $client, $logger), $dispatcher, $logger),
98+
new SesApiAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1', 'endpoint' => 'https://example.com:8080', 'sessionToken' => 'se$sion']), null, $client, $logger), null, $logger),
9899
];
99100

100101
yield [
101102
new Dsn('ses+https', 'default', self::USER, self::PASSWORD),
102-
new SesHttpAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1']), null, $client, $logger), $dispatcher, $logger),
103+
new SesHttpAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1']), null, $client, $logger), null, $logger),
103104
];
104105

105106
yield [
106107
new Dsn('ses', 'default', self::USER, self::PASSWORD),
107-
new SesHttpAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1']), null, $client, $logger), $dispatcher, $logger),
108+
new SesHttpAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1']), null, $client, $logger), null, $logger),
108109
];
109110

110111
yield [
111112
new Dsn('ses+https', 'example.com', self::USER, self::PASSWORD, 8080),
112-
new SesHttpAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1', 'endpoint' => 'https://example.com:8080']), null, $client, $logger), $dispatcher, $logger),
113+
new SesHttpAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1', 'endpoint' => 'https://example.com:8080']), null, $client, $logger), null, $logger),
113114
];
114115

115116
yield [
116117
new Dsn('ses+https', 'default', self::USER, self::PASSWORD, null, ['region' => 'eu-west-2']),
117-
new SesHttpAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-2']), null, $client, $logger), $dispatcher, $logger),
118+
new SesHttpAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-2']), null, $client, $logger), null, $logger),
118119
];
119120

120121
yield [
121122
new Dsn('ses+https', 'default', self::USER, self::PASSWORD, null, ['session_token' => 'se$sion']),
122-
new SesHttpAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1', 'sessionToken' => 'se$sion']), null, $client, $logger), $dispatcher, $logger),
123+
new SesHttpAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1', 'sessionToken' => 'se$sion']), null, $client, $logger), null, $logger),
123124
];
124125

125126
yield [
126127
new Dsn('ses', 'default', self::USER, self::PASSWORD, null, ['session_token' => 'se$sion']),
127-
new SesHttpAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1', 'sessionToken' => 'se$sion']), null, $client, $logger), $dispatcher, $logger),
128+
new SesHttpAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1', 'sessionToken' => 'se$sion']), null, $client, $logger), null, $logger),
128129
];
129130

130131
yield [
131132
new Dsn('ses+https', 'example.com', self::USER, self::PASSWORD, 8080, ['session_token' => 'se$sion']),
132-
new SesHttpAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1', 'endpoint' => 'https://example.com:8080', 'sessionToken' => 'se$sion']), null, $client, $logger), $dispatcher, $logger),
133+
new SesHttpAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-1', 'endpoint' => 'https://example.com:8080', 'sessionToken' => 'se$sion']), null, $client, $logger), null, $logger),
133134
];
134135

135136
yield [
136137
new Dsn('ses+https', 'default', self::USER, self::PASSWORD, null, ['region' => 'eu-west-2', 'session_token' => 'se$sion']),
137-
new SesHttpAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-2', 'sessionToken' => 'se$sion']), null, $client, $logger), $dispatcher, $logger),
138+
new SesHttpAsyncAwsTransport(new SesClient(Configuration::create(['accessKeyId' => self::USER, 'accessKeySecret' => self::PASSWORD, 'region' => 'eu-west-2', 'sessionToken' => 'se$sion']), null, $client, $logger), null, $logger),
138139
];
139140

140141
yield [
141142
new Dsn('ses+smtp', 'default', self::USER, self::PASSWORD),
142-
new SesSmtpTransport(self::USER, self::PASSWORD, null, $dispatcher, $logger),
143+
new SesSmtpTransport(self::USER, self::PASSWORD, null, null, $logger),
143144
];
144145

145146
yield [
146147
new Dsn('ses+smtp', 'default', self::USER, self::PASSWORD, null, ['region' => 'eu-west-1']),
147-
new SesSmtpTransport(self::USER, self::PASSWORD, 'eu-west-1', $dispatcher, $logger),
148+
new SesSmtpTransport(self::USER, self::PASSWORD, 'eu-west-1', null, $logger),
148149
];
149150

150151
yield [
151152
new Dsn('ses+smtps', 'default', self::USER, self::PASSWORD, null, ['region' => 'eu-west-1']),
152-
new SesSmtpTransport(self::USER, self::PASSWORD, 'eu-west-1', $dispatcher, $logger),
153+
new SesSmtpTransport(self::USER, self::PASSWORD, 'eu-west-1', null, $logger),
153154
];
154155

155156
yield [
156157
new Dsn('ses+smtps', 'default', self::USER, self::PASSWORD, null, ['region' => 'eu-west-1', 'ping_threshold' => '10']),
157-
(new SesSmtpTransport(self::USER, self::PASSWORD, 'eu-west-1', $dispatcher, $logger))->setPingThreshold(10),
158+
(new SesSmtpTransport(self::USER, self::PASSWORD, 'eu-west-1', null, $logger))->setPingThreshold(10),
158159
];
159160
}
160161

‎src/Symfony/Component/Mailer/Bridge/Google/Tests/Transport/GmailTransportFactoryTest.php

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111

1212
namespace Symfony\Component\Mailer\Bridge\Google\Tests\Transport;
1313

14+
use Psr\Log\NullLogger;
15+
use Symfony\Component\HttpClient\MockHttpClient;
1416
use Symfony\Component\Mailer\Bridge\Google\Transport\GmailSmtpTransport;
1517
use Symfony\Component\Mailer\Bridge\Google\Transport\GmailTransportFactory;
1618
use Symfony\Component\Mailer\Test\TransportFactoryTestCase;
@@ -19,9 +21,9 @@
1921

2022
class GmailTransportFactoryTest extends TransportFactoryTestCase
2123
{
22-
public static function getFactory(): TransportFactoryInterface
24+
public function getFactory(): TransportFactoryInterface
2325
{
24-
return new GmailTransportFactory(self::getDispatcher(), null, self::getLogger());
26+
return new GmailTransportFactory(null, new MockHttpClient(), new NullLogger());
2527
}
2628

2729
public static function supportsProvider(): iterable
@@ -51,17 +53,17 @@ public static function createProvider(): iterable
5153
{
5254
yield [
5355
new Dsn('gmail', 'default', self::USER, self::PASSWORD),
54-
new GmailSmtpTransport(self::USER, self::PASSWORD, self::getDispatcher(), self::getLogger()),
56+
new GmailSmtpTransport(self::USER, self::PASSWORD, null, new NullLogger()),
5557
];
5658

5759
yield [
5860
new Dsn('gmail+smtp', 'default', self::USER, self::PASSWORD),
59-
new GmailSmtpTransport(self::USER, self::PASSWORD, self::getDispatcher(), self::getLogger()),
61+
new GmailSmtpTransport(self::USER, self::PASSWORD, null, new NullLogger()),
6062
];
6163

6264
yield [
6365
new Dsn('gmail+smtps', 'default', self::USER, self::PASSWORD),
64-
new GmailSmtpTransport(self::USER, self::PASSWORD, self::getDispatcher(), self::getLogger()),
66+
new GmailSmtpTransport(self::USER, self::PASSWORD, null, new NullLogger()),
6567
];
6668
}
6769

‎src/Symfony/Component/Mailer/Bridge/Mailchimp/Tests/Transport/MandrillTransportFactoryTest.php

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111

1212
namespace Symfony\Component\Mailer\Bridge\Mailchimp\Tests\Transport;
1313

14+
use Psr\Log\NullLogger;
15+
use Symfony\Component\HttpClient\MockHttpClient;
1416
use Symfony\Component\Mailer\Bridge\Mailchimp\Transport\MandrillApiTransport;
1517
use Symfony\Component\Mailer\Bridge\Mailchimp\Transport\MandrillHttpTransport;
1618
use Symfony\Component\Mailer\Bridge\Mailchimp\Transport\MandrillSmtpTransport;
@@ -21,9 +23,9 @@
2123

2224
class MandrillTransportFactoryTest extends TransportFactoryTestCase
2325
{
24-
public static function getFactory(): TransportFactoryInterface
26+
public function getFactory(): TransportFactoryInterface
2527
{
26-
return new MandrillTransportFactory(self::getDispatcher(), self::getClient(), self::getLogger());
28+
return new MandrillTransportFactory(null, new MockHttpClient(), new NullLogger());
2729
}
2830

2931
public static function supportsProvider(): iterable
@@ -61,43 +63,42 @@ public static function supportsProvider(): iterable
6163

6264
public static function createProvider(): iterable
6365
{
64-
$client = self::getClient();
65-
$dispatcher = self::getDispatcher();
66-
$logger = self::getLogger();
66+
$client = new MockHttpClient();
67+
$logger = new NullLogger();
6768

6869
yield [
6970
new Dsn('mandrill+api', 'default', self::USER),
70-
new MandrillApiTransport(self::USER, $client, $dispatcher, $logger),
71+
new MandrillApiTransport(self::USER, $client, null, $logger),
7172
];
7273

7374
yield [
7475
new Dsn('mandrill+api', 'example.com', self::USER, '', 8080),
75-
(new MandrillApiTransport(self::USER, $client, $dispatcher, $logger))->setHost('example.com')->setPort(8080),
76+
(new MandrillApiTransport(self::USER, $client, null, $logger))->setHost('example.com')->setPort(8080),
7677
];
7778

7879
yield [
7980
new Dsn('mandrill', 'default', self::USER),
80-
new MandrillHttpTransport(self::USER, $client, $dispatcher, $logger),
81+
new MandrillHttpTransport(self::USER, $client, null, $logger),
8182
];
8283

8384
yield [
8485
new Dsn('mandrill+https', 'default', self::USER),
85-
new MandrillHttpTransport(self::USER, $client, $dispatcher, $logger),
86+
new MandrillHttpTransport(self::USER, $client, null, $logger),
8687
];
8788

8889
yield [
8990
new Dsn('mandrill+https', 'example.com', self::USER, '', 8080),
90-
(new MandrillHttpTransport(self::USER, $client, $dispatcher, $logger))->setHost('example.com')->setPort(8080),
91+
(new MandrillHttpTransport(self::USER, $client, null, $logger))->setHost('example.com')->setPort(8080),
9192
];
9293

9394
yield [
9495
new Dsn('mandrill+smtp', 'default', self::USER, self::PASSWORD),
95-
new MandrillSmtpTransport(self::USER, self::PASSWORD, $dispatcher, $logger),
96+
new MandrillSmtpTransport(self::USER, self::PASSWORD, null, $logger),
9697
];
9798

9899
yield [
99100
new Dsn('mandrill+smtps', 'default', self::USER, self::PASSWORD),
100-
new MandrillSmtpTransport(self::USER, self::PASSWORD, $dispatcher, $logger),
101+
new MandrillSmtpTransport(self::USER, self::PASSWORD, null, $logger),
101102
];
102103
}
103104

‎src/Symfony/Component/Mailer/Bridge/Mailgun/Tests/Transport/MailgunTransportFactoryTest.php

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111

1212
namespace Symfony\Component\Mailer\Bridge\Mailgun\Tests\Transport;
1313

14+
use Psr\Log\NullLogger;
15+
use Symfony\Component\HttpClient\MockHttpClient;
1416
use Symfony\Component\Mailer\Bridge\Mailgun\Transport\MailgunApiTransport;
1517
use Symfony\Component\Mailer\Bridge\Mailgun\Transport\MailgunHttpTransport;
1618
use Symfony\Component\Mailer\Bridge\Mailgun\Transport\MailgunSmtpTransport;
@@ -21,9 +23,9 @@
2123

2224
class MailgunTransportFactoryTest extends TransportFactoryTestCase
2325
{
24-
public static function getFactory(): TransportFactoryInterface
26+
public function getFactory(): TransportFactoryInterface
2527
{
26-
return new MailgunTransportFactory(self::getDispatcher(), self::getClient(), self::getLogger());
28+
return new MailgunTransportFactory(null, new MockHttpClient(), new NullLogger());
2729
}
2830

2931
public static function supportsProvider(): iterable
@@ -61,48 +63,47 @@ public static function supportsProvider(): iterable
6163

6264
public static function createProvider(): iterable
6365
{
64-
$client = self::getClient();
65-
$dispatcher = self::getDispatcher();
66-
$logger = self::getLogger();
66+
$client = new MockHttpClient();
67+
$logger = new NullLogger();
6768

6869
yield [
6970
new Dsn('mailgun+api', 'default', self::USER, self::PASSWORD),
70-
new MailgunApiTransport(self::USER, self::PASSWORD, null, $client, $dispatcher, $logger),
71+
new MailgunApiTransport(self::USER, self::PASSWORD, null, $client, null, $logger),
7172
];
7273

7374
yield [
7475
new Dsn('mailgun+api', 'default', self::USER, self::PASSWORD, null, ['region' => 'eu']),
75-
new MailgunApiTransport(self::USER, self::PASSWORD, 'eu', $client, $dispatcher, $logger),
76+
new MailgunApiTransport(self::USER, self::PASSWORD, 'eu', $client, null, $logger),
7677
];
7778

7879
yield [
7980
new Dsn('mailgun+api', 'example.com', self::USER, self::PASSWORD, 8080),
80-
(new MailgunApiTransport(self::USER, self::PASSWORD, null, $client, $dispatcher, $logger))->setHost('example.com')->setPort(8080),
81+
(new MailgunApiTransport(self::USER, self::PASSWORD, null, $client, null, $logger))->setHost('example.com')->setPort(8080),
8182
];
8283

8384
yield [
8485
new Dsn('mailgun', 'default', self::USER, self::PASSWORD),
85-
new MailgunHttpTransport(self::USER, self::PASSWORD, null, $client, $dispatcher, $logger),
86+
new MailgunHttpTransport(self::USER, self::PASSWORD, null, $client, null, $logger),
8687
];
8788

8889
yield [
8990
new Dsn('mailgun+https', 'default', self::USER, self::PASSWORD),
90-
new MailgunHttpTransport(self::USER, self::PASSWORD, null, $client, $dispatcher, $logger),
91+
new MailgunHttpTransport(self::USER, self::PASSWORD, null, $client, null, $logger),
9192
];
9293

9394
yield [
9495
new Dsn('mailgun+https', 'example.com', self::USER, self::PASSWORD, 8080),
95-
(new MailgunHttpTransport(self::USER, self::PASSWORD, null, $client, $dispatcher, $logger))->setHost('example.com')->setPort(8080),
96+
(new MailgunHttpTransport(self::USER, self::PASSWORD, null, $client, null, $logger))->setHost('example.com')->setPort(8080),
9697
];
9798

9899
yield [
99100
new Dsn('mailgun+smtp', 'default', self::USER, self::PASSWORD),
100-
new MailgunSmtpTransport(self::USER, self::PASSWORD, null, $dispatcher, $logger),
101+
new MailgunSmtpTransport(self::USER, self::PASSWORD, null, null, $logger),
101102
];
102103

103104
yield [
104105
new Dsn('mailgun+smtps', 'default', self::USER, self::PASSWORD),
105-
new MailgunSmtpTransport(self::USER, self::PASSWORD, null, $dispatcher, $logger),
106+
new MailgunSmtpTransport(self::USER, self::PASSWORD, null, null, $logger),
106107
];
107108
}
108109

0 commit comments

Comments
 (0)
0