[Serializer] Add XmlEncoder:: defaults directly to argument, per @ostrolucky.

James Sansbury · James Sansbury · commit dec179a79ff4 · 2018-03-07T10:07:40.000-05:00
diff --git a/src/Symfony/Component/Serializer/Encoder/XmlEncoder.php b/src/Symfony/Component/Serializer/Encoder/XmlEncoder.php
@@ -45,11 +45,11 @@ class XmlEncoder implements EncoderInterface, DecoderInterface, NormalizationAwa
      * @param int|null $loadOptions      A bit field of LIBXML_* constants
      * @param int[]    $ignoredNodeTypes an array of ignored XML node types, each one of the DOM Predefined XML_* Constants
      */
-    public function __construct(string $rootNodeName = 'response', int $loadOptions = null, array $ignoredNodeTypes = null)
+    public function __construct(string $rootNodeName = 'response', int $loadOptions = null, array $ignoredNodeTypes = array(XML_PI_NODE, XML_COMMENT_NODE))
     {
         $this->rootNodeName = $rootNodeName;
         $this->loadOptions = null !== $loadOptions ? $loadOptions : LIBXML_NONET | LIBXML_NOBLANKS;
-        $this->ignoredNodeTypes = !empty($ignoredNodeTypes) ? $ignoredNodeTypes : array(XML_PI_NODE, XML_COMMENT_NODE);
+        $this->ignoredNodeTypes = $ignoredNodeTypes;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -45,11 +45,11 @@ class XmlEncoder implements EncoderInterface, DecoderInterface, NormalizationAwa`
`45`	`45`	`* @param int\|null $loadOptions A bit field of LIBXML_* constants`
`46`	`46`	`* @param int[] $ignoredNodeTypes an array of ignored XML node types, each one of the DOM Predefined XML_* Constants`
`47`	`47`	`*/`
`48`		`- public function __construct(string $rootNodeName = 'response', int $loadOptions = null, array $ignoredNodeTypes = null)`
	`48`	`+ public function __construct(string $rootNodeName = 'response', int $loadOptions = null, array $ignoredNodeTypes = array(XML_PI_NODE, XML_COMMENT_NODE))`
`49`	`49`	`{`
`50`	`50`	`$this->rootNodeName = $rootNodeName;`
`51`	`51`	`$this->loadOptions = null !== $loadOptions ? $loadOptions : LIBXML_NONET \| LIBXML_NOBLANKS;`
`52`		`- $this->ignoredNodeTypes = !empty($ignoredNodeTypes) ? $ignoredNodeTypes : array(XML_PI_NODE, XML_COMMENT_NODE);`
	`52`	`+ $this->ignoredNodeTypes = $ignoredNodeTypes;`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`/**`