minor #49485 [String] Use same alphabet in ByteString::fromRandom test (kerbert101)

nicolas-grekas · nicolas-grekas · commit ddfd2ac7b0cb · 2023-02-22T11:33:25.000+01:00
This PR was merged into the 5.4 branch. Discussion ---------- [String] Use same alphabet in ByteString::fromRandom test | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | NA | License | MIT | Doc PR | NA `testFromRandom` in `ByteStringTest` tests the fromRandom method in ByteString, but uses a different alphabet. Apparently, some characters were left out in the alphabet of ByteString to prevent confusion. I believe the same alphabet should be used in the test. Commits ------- d422ac1 [String] Use same alphabet for ByteString::fromRandom tests
diff --git a/src/Symfony/Component/String/Tests/ByteStringTest.php b/src/Symfony/Component/String/Tests/ByteStringTest.php
@@ -28,7 +28,7 @@ public function testFromRandom()
 
         self::assertSame(32, $random->length());
         foreach ($random->chunk() as $char) {
-            self::assertNotNull((new ByteString('ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789'))->indexOf($char));
+            self::assertNotNull((new ByteString('123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz'))->indexOf($char));
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ public function testFromRandom()`
`28`	`28`
`29`	`29`	`self::assertSame(32, $random->length());`
`30`	`30`	`foreach ($random->chunk() as $char) {`
`31`		`- self::assertNotNull((new ByteString('ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789'))->indexOf($char));`
	`31`	`+ self::assertNotNull((new ByteString('123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz'))->indexOf($char));`
`32`	`32`	`}`
`33`	`33`	`}`
`34`	`34`