bug #15682 [Form] Added exception when setAutoInitialize() is called when locked (jaytaph)

fabpot · fabpot · commit ddf79da4f9ac · 2015-09-26T10:25:01.000+02:00
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #15682). Discussion ---------- [Form] Added exception when setAutoInitialize() is called when locked | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | It seems that this method was missing a "locked" check, since it changes state and a locked instance should be immutable. However, because `setAutoInitialize()` is useful during the building of a form, it doesn't really matter a lot whether or not it is changed. But for consistency, it would be nicer if this method too was checked. Commits ------- c269d6f Added exception when setAutoInitialize is called when locked
diff --git a/src/Symfony/Component/Form/FormConfigBuilder.php b/src/Symfony/Component/Form/FormConfigBuilder.php
@@ -855,6 +855,10 @@ public function setRequestHandler(RequestHandlerInterface $requestHandler)
      */
     public function setAutoInitialize($initialize)
     {
+        if ($this->locked) {
+            throw new BadMethodCallException('FormConfigBuilder methods cannot be accessed anymore once the builder is turned into a FormConfigInterface instance.');
+        }
+
         $this->autoInitialize = (bool) $initialize;
 
         return $this;
