minor #24650 Fix phpdoc and unnecessary sprintf (TysonAndre)

ogizanagi · ogizanagi · commit dde192a3af65 · 2017-10-21T13:51:20.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- Fix phpdoc and unnecessary sprintf (detected by static analysis) `%1$::`: is not a format string, it should be `%1$s::` Simplify no-op sprintf. | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? |no | BC breaks? | no | Deprecations? | no  | Tests pass? | | Fixed tickets | | License | MIT | Doc PR | Commits ------- e64baf5 Fix phpdoc and unnecessary sprintf
diff --git a/src/Symfony/Component/DependencyInjection/Loader/Configurator/DefaultsConfigurator.php b/src/Symfony/Component/DependencyInjection/Loader/Configurator/DefaultsConfigurator.php
@@ -40,7 +40,7 @@ class DefaultsConfigurator extends AbstractServiceConfigurator
     final public function tag($name, array $attributes = array())
     {
         if (!is_string($name) || '' === $name) {
-            throw new InvalidArgumentException(sprintf('The tag name in "_defaults" must be a non-empty string.'));
+            throw new InvalidArgumentException('The tag name in "_defaults" must be a non-empty string.');
         }
 
         foreach ($attributes as $attribute => $value) {
diff --git a/src/Symfony/Component/Routing/Loader/Configurator/CollectionConfigurator.php b/src/Symfony/Component/Routing/Loader/Configurator/CollectionConfigurator.php
@@ -42,7 +42,7 @@ public function __destruct()
      * Adds a route.
      *
      * @param string $name
-     * @param string $value
+     * @param string $path
      *
      * @return RouteConfigurator
      */

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ class DefaultsConfigurator extends AbstractServiceConfigurator`
`40`	`40`	`final public function tag($name, array $attributes = array())`
`41`	`41`	`{`
`42`	`42`	`if (!is_string($name) \|\| '' === $name) {`
`43`		`- throw new InvalidArgumentException(sprintf('The tag name in "_defaults" must be a non-empty string.'));`
	`43`	`+ throw new InvalidArgumentException('The tag name in "_defaults" must be a non-empty string.');`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`foreach ($attributes as $attribute => $value) {`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public function __destruct()`
`42`	`42`	`* Adds a route.`
`43`	`43`	`*`
`44`	`44`	`* @param string $name`
`45`		`- * @param string $value`
	`45`	`+ * @param string $path`
`46`	`46`	`*`
`47`	`47`	`* @return RouteConfigurator`
`48`	`48`	`*/`