bug #59357 [HttpKernel] Don't override existing LoggerInterface autowiring alias in LoggerPass (nicolas-grekas)

fabpot · fabpot · commit dd50db5241ca · 2025-01-04T09:51:00.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [HttpKernel] Don't override existing `LoggerInterface` autowiring alias in `LoggerPass` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Something we missed in #24300 Explicit configuration should always have highest precedence, yet LoggerPass ignores the existing autowiring alias at the moment. Commits ------- 771a79d [HttpKernel] Don't override existing LoggerInterface autowiring alias in LoggerPass
diff --git a/src/Symfony/Component/HttpKernel/DependencyInjection/LoggerPass.php b/src/Symfony/Component/HttpKernel/DependencyInjection/LoggerPass.php
@@ -30,7 +30,9 @@ class LoggerPass implements CompilerPassInterface
      */
     public function process(ContainerBuilder $container)
     {
-        $container->setAlias(LoggerInterface::class, 'logger');
+        if (!$container->has(LoggerInterface::class)) {
+            $container->setAlias(LoggerInterface::class, 'logger');
+        }
 
         if ($container->has('logger')) {
             return;
diff --git a/src/Symfony/Component/HttpKernel/Tests/DependencyInjection/LoggerPassTest.php b/src/Symfony/Component/HttpKernel/Tests/DependencyInjection/LoggerPassTest.php
@@ -53,4 +53,15 @@ public function testRegisterLogger()
         $this->assertSame(Logger::class, $definition->getClass());
         $this->assertFalse($definition->isPublic());
     }
+
+    public function testAutowiringAliasIsPreserved()
+    {
+        $container = new ContainerBuilder();
+        $container->setParameter('kernel.debug', false);
+        $container->setAlias(LoggerInterface::class, 'my_logger');
+
+        (new LoggerPass())->process($container);
+
+        $this->assertSame('my_logger', (string) $container->getAlias(LoggerInterface::class));
+    }
 }
