bug #37890 [Notifier] Fixed base_uri while call auth/time API (leblanc-simon)

fabpot · fabpot · commit dd190565dc45 · 2020-08-20T07:28:57.000+02:00
This PR was squashed before being merged into the 5.1 branch. Discussion ---------- [Notifier] Fixed base_uri while call auth/time API This patch fixed the base_uri missing while we call the auth/time OVH API. * Without this patch, the API call failed because the URL is wrong : eu.api.ovh.com/auth/time * With this patch, the API call successed, URL is : https://eu.api.ovh.com/1.0/auth/time | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fixed base_uri while call auth/time API | License | MIT Commits ------- 2f91485 [Notifier] Fixed base_uri while call auth/time API
diff --git a/src/Symfony/Component/Notifier/Bridge/OvhCloud/OvhCloudTransport.php b/src/Symfony/Component/Notifier/Bridge/OvhCloud/OvhCloudTransport.php
@@ -88,7 +88,7 @@ protected function doSend(MessageInterface $message): void
         if (200 !== $response->getStatusCode()) {
             $error = $response->toArray(false);
 
-            throw new TransportException(sprintf('Unable to send the SMS: %s.', $error['message']), $response);
+            throw new TransportException(sprintf('Unable to send the SMS: "%s".', $error['message']), $response);
         }
     }
 
@@ -97,7 +97,7 @@ protected function doSend(MessageInterface $message): void
      */
     private function calculateTimeDelta(): int
     {
-        $endpoint = sprintf('%s/auth/time', $this->getEndpoint());
+        $endpoint = sprintf('https://%s/1.0/auth/time', $this->getEndpoint());
         $response = $this->client->request('GET', $endpoint);
 
         return $response->getContent() - time();

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ protected function doSend(MessageInterface $message): void`
`88`	`88`	`if (200 !== $response->getStatusCode()) {`
`89`	`89`	`$error = $response->toArray(false);`
`90`	`90`
`91`		`- throw new TransportException(sprintf('Unable to send the SMS: %s.', $error['message']), $response);`
	`91`	`+ throw new TransportException(sprintf('Unable to send the SMS: "%s".', $error['message']), $response);`
`92`	`92`	`}`
`93`	`93`	`}`
`94`	`94`
`@@ -97,7 +97,7 @@ protected function doSend(MessageInterface $message): void`
`97`	`97`	`*/`
`98`	`98`	`private function calculateTimeDelta(): int`
`99`	`99`	`{`
`100`		`- $endpoint = sprintf('%s/auth/time', $this->getEndpoint());`
	`100`	`+ $endpoint = sprintf('https://%s/1.0/auth/time', $this->getEndpoint());`
`101`	`101`	`$response = $this->client->request('GET', $endpoint);`
`102`	`102`
`103`	`103`	`return $response->getContent() - time();`