8000 minor #48578 [Console]  Fix tests (chalasr) · symfony/symfony@dc803d7 · GitHub
[go: up one dir, main page]
Skip to content

Commit dc803d7

Browse files
chalasrchalasr
committed
minor #48578 [Console]  Fix tests (chalasr)
This PR was merged into the 6.3 branch. Discussion ---------- [Console]  Fix tests | Q | A | ------------- | --- | Branch? | 6.3 for features / 5.4, 6.0, 6.1, or 6.2 for bug fixes <!-- see below --> | Bug fix? | yes/no | New feature? | yes/no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | yes/no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Commits ------- 82d79b4 [Console] Fix tests
2 parents 78d9cdc + 82d79b4 commit dc803d7

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

‎src/Symfony/Component/Console/Tests/ApplicationTest.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2132,8 +2132,6 @@ class BaseSignableCommand extends Command
21322132
private $emitsSignal;
21332133
private $signal;
21342134

2135-
protected static $defaultName = 'signal';
2136-
21372135
public function __construct(bool $emitsSignal = true, int $signal = \SIGUSR1)
21382136
{
21392137
parent::__construct();
@@ -2173,10 +2171,9 @@ public function handleSignal(int $signal): void
21732171
}
21742172
}
21752173

2174+
#[AsCommand(name: 'signal')]
21762175
class TerminatableCommand extends BaseSignableCommand implements SignalableCommandInterface
21772176
{
2178-
protected static $defaultName = 'signal';
2179-
21802177
public function getSubscribedSignals(): array
21812178
{
21822179
return SignalRegistry::isSupported() ? [\SIGINT] : [];

0 commit comments

Comments
 (0)
0