bug #57832 [DependencyInjection] Do not try to load default method name on interface (lyrixx)

fabpot · fabpot · commit dbccb6b69885 · 2024-07-26T09:08:18.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Do not try to load default method name on interface | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #57830 | License | MIT Commits ------- ac78bba [DependencyInjection] Do not try to load default method name on interface
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php b/src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php
@@ -133,6 +133,10 @@ public static function getDefault(ContainerBuilder $container, string $serviceId
             return null;
         }
 
+        if ($r->isInterface()) {
+            return null;
+        }
+
         if (null !== $indexAttribute) {
             $service = $class !== $serviceId ? sprintf('service "%s"', $serviceId) : 'on the corresponding service';
             $message = [sprintf('Either method "%s::%s()" should ', $class, $defaultMethod), sprintf(' or tag "%s" on %s is missing attribute "%s".', $tagName, $service, $indexAttribute)];
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/PriorityTaggedServiceTraitTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/PriorityTaggedServiceTraitTest.php
@@ -151,13 +151,16 @@ public function testTheIndexedTagsByDefaultIndexMethod()
 
         $container->register('service3', IntTagClass::class)->addTag('my_custom_tag');
 
+        $container->register('service4', HelloInterface::class)->addTag('my_custom_tag');
+
         $priorityTaggedServiceTraitImplementation = new PriorityTaggedServiceTraitImplementation();
 
         $tag = new TaggedIteratorArgument('my_custom_tag', 'foo', 'getFooBar');
         $expected = [
             'bar_tab_class_with_defaultmethod' => new TypedReference('service2', BarTagClass::class),
             'service1' => new TypedReference('service1', FooTagClass::class),
             '10' => new TypedReference('service3', IntTagClass::class),
+            'service4' => new TypedReference('service4', HelloInterface::class),
         ];
         $services = $priorityTaggedServiceTraitImplementation->test($tag, $container);
         $this->assertSame(array_keys($expected), array_keys($services));
@@ -244,3 +247,8 @@ class HelloNamedService extends \stdClass
 class HelloNamedService2
 {
 }
+
+interface HelloInterface
+{
+    public static function getFooBar(): string;
+}
