minor #45739 [HttpFoundation] Improve Cookie constructor to use constant (JohJohan)

fabpot · fabpot · commit db99c0771af3 · 2022-03-17T07:53:39.000+01:00
This PR was merged into the 6.1 branch. Discussion ---------- [HttpFoundation] Improve Cookie constructor to use constant | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | no | License | MIT | Doc PR | no Improve Cookie constructor to use a constant from the same class just like the `create` function. Commits ------- d929ca3 [HttpFoundation] Improve Cookie constructor to use constant
diff --git a/src/Symfony/Component/HttpFoundation/Cookie.php b/src/Symfony/Component/HttpFoundation/Cookie.php
@@ -87,7 +87,7 @@ public static function create(string $name, string $value = null, int|string|\Da
      *
      * @throws \InvalidArgumentException
      */
-    public function __construct(string $name, string $value = null, int|string|\DateTimeInterface $expire = 0, ?string $path = '/', string $domain = null, bool $secure = null, bool $httpOnly = true, bool $raw = false, ?string $sameSite = 'lax')
+    public function __construct(string $name, string $value = null, int|string|\DateTimeInterface $expire = 0, ?string $path = '/', string $domain = null, bool $secure = null, bool $httpOnly = true, bool $raw = false, ?string $sameSite = self::SAMESITE_LAX)
     {
         // from PHP source code
         if ($raw && false !== strpbrk($name, self::RESERVED_CHARS_LIST)) {

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ public static function create(string $name, string $value = null, int\|string\|\Da`
`87`	`87`	`*`
`88`	`88`	`* @throws \InvalidArgumentException`
`89`	`89`	`*/`
`90`		`- public function __construct(string $name, string $value = null, int\|string\|\DateTimeInterface $expire = 0, ?string $path = '/', string $domain = null, bool $secure = null, bool $httpOnly = true, bool $raw = false, ?string $sameSite = 'lax')`
	`90`	`+ public function __construct(string $name, string $value = null, int\|string\|\DateTimeInterface $expire = 0, ?string $path = '/', string $domain = null, bool $secure = null, bool $httpOnly = true, bool $raw = false, ?string $sameSite = self::SAMESITE_LAX)`
`91`	`91`	`{`
`92`	`92`	`// from PHP source code`
`93`	`93`	`if ($raw && false !== strpbrk($name, self::RESERVED_CHARS_LIST)) {`