Stop deleting messages on rejection

Steveb-p · web-flow · commit db73c02e2ce8 · 2020-05-06T15:47:05.000+02:00
Unless `delete_after_ack` configuration is set to `true`. Fixes #36619
diff --git a/src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php b/src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
@@ -343,7 +343,9 @@ public function reject(string $id): void
     {
         try {
             $deleted = $this->connection->xack($this->stream, $this->group, [$id]);
-            $deleted = $this->connection->xdel($this->stream, [$id]) && $deleted;
+            if ($this->deleteAfterAck) {
+                $deleted = $this->connection->xdel($this->stream, [$id]) && $deleted;
+            }
         } catch (\RedisException $e) {
             throw new TransportException($e->getMessage(), 0, $e);
         }

Original file line number	Diff line number	Diff line change
`@@ -343,7 +343,9 @@ public function reject(string $id): void`
`343`	`343`	`{`
`344`	`344`	`try {`
`345`	`345`	`$deleted = $this->connection->xack($this->stream, $this->group, [$id]);`
`346`		`- $deleted = $this->connection->xdel($this->stream, [$id]) && $deleted;`
	`346`	`+ if ($this->deleteAfterAck) {`
	`347`	`+ $deleted = $this->connection->xdel($this->stream, [$id]) && $deleted;`
	`348`	`+ }`
`347`	`349`	`} catch (\RedisException $e) {`
`348`	`350`	`throw new TransportException($e->getMessage(), 0, $e);`
`349`	`351`	`}`