minor #36428 [Form] Removed legacy check in ValidationListener (HeahDude)

fabpot · fabpot · commit db733da440f6 · 2020-04-12T09:19:14.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Form] Removed legacy check in `ValidationListener` | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | ~ A left over of #13198, should have been removed in 3.0. The tests don't use `null` anymore, no update needed here, this is just about removing dead code. Commits ------- e479e51 [Form] Removed legacy check in `ValidationListener`
diff --git a/src/Symfony/Component/Form/Extension/Validator/EventListener/ValidationListener.php b/src/Symfony/Component/Form/Extension/Validator/EventListener/ValidationListener.php
@@ -55,8 +55,7 @@ public function validateForm(FormEvent $event)
             foreach ($this->validator->validate($form) as $violation) {
                 // Allow the "invalid" constraint to be put onto
                 // non-synchronized forms
-                // ConstraintViolation::getConstraint() must not expect to provide a constraint as long as Symfony\Component\Validator\ExecutionContext exists (before 3.0)
-                $allowNonSynchronized = (null === $violation->getConstraint() || $violation->getConstraint() instanceof Form) && Form::NOT_SYNCHRONIZED_ERROR === $violation->getCode();
+                $allowNonSynchronized = $violation->getConstraint() instanceof Form && Form::NOT_SYNCHRONIZED_ERROR === $violation->getCode();
 
                 $this->violationMapper->mapViolation($violation, $form, $allowNonSynchronized);
             }

Original file line number	Diff line number	Diff line change
`@@ -55,8 +55,7 @@ public function validateForm(FormEvent $event)`
`55`	`55`	`foreach ($this->validator->validate($form) as $violation) {`
`56`	`56`	`// Allow the "invalid" constraint to be put onto`
`57`	`57`	`// non-synchronized forms`
`58`		`- // ConstraintViolation::getConstraint() must not expect to provide a constraint as long as Symfony\Component\Validator\ExecutionContext exists (before 3.0)`
`59`		`- $allowNonSynchronized = (null === $violation->getConstraint() \|\| $violation->getConstraint() instanceof Form) && Form::NOT_SYNCHRONIZED_ERROR === $violation->getCode();`
	`58`	`+ $allowNonSynchronized = $violation->getConstraint() instanceof Form && Form::NOT_SYNCHRONIZED_ERROR === $violation->getCode();`
`60`	`59`
`61`	`60`	`$this->violationMapper->mapViolation($violation, $form, $allowNonSynchronized);`
`62`	`61`	`}`