minor #49669 [DomCrawler] Improve html5Parser tests (victor-prdh)

nicolas-grekas · nicolas-grekas · commit da9e54a27df1 · 2023-03-13T08:55:22.000+01:00
This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [DomCrawler] Improve html5Parser tests | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | / | License | MIT | Doc PR | / Hi ! As mentioned by `@Bilge` in #49121 (comment), test to ensure the new html5Parser strategy wasn't the best ! So i worked a little on this subject and i come with this new proposal ! Thanks Commits ------- 1231d75 [DomCrawler] Improve html5Parser tests
diff --git a/src/Symfony/Component/DomCrawler/Tests/Html5ParserCrawlerTest.php b/src/Symfony/Component/DomCrawler/Tests/Html5ParserCrawlerTest.php
@@ -60,6 +60,24 @@ public function testHtml5ParserNotSameAsNativeParserForSpecificHtml()
         $this->assertNotEquals($nativeCrawler->filterXPath('//h1')->text(), $html5Crawler->filterXPath('//h1')->text(), 'Native parser and Html5 parser must be different');
     }
 
+    /**
+     * @testWith [true]
+     *           [false]
+     */
+    public function testHasHtml5Parser(bool $useHtml5Parser)
+    {
+        $crawler = $this->createCrawler(null, null, null, $useHtml5Parser);
+
+        $r = new \ReflectionProperty($crawler::class, 'html5Parser');
+        $html5Parser = $r->getValue($crawler);
+
+        if ($useHtml5Parser) {
+            $this->assertInstanceOf(\Masterminds\HTML5::class, $html5Parser, 'Html5Parser must be a Masterminds\HTML5 instance');
+        } else {
+            $this->assertNull($html5Parser, 'Html5Parser must be null');
+        }
+    }
+
     public static function validHtml5Provider(): iterable
     {
         $html = self::getDoctype().'<html><body><h1><p>Foo</p></h1></body></html>';
