Merge branch '3.4' into 4.4

nicolas-grekas · nicolas-grekas · commit da8b9552ad9e · 2020-05-08T12:54:34.000+02:00
* 3.4:
  [3.4] CS fixes
diff --git a/src/Symfony/Component/Config/Tests/Definition/Builder/ExprBuilderTest.php b/src/Symfony/Component/Config/Tests/Definition/Builder/ExprBuilderTest.php
@@ -149,7 +149,7 @@ public function testThenEmptyArrayExpression()
     /**
      * @dataProvider castToArrayValues
      */
-    public function testcastToArrayExpression($configValue, $expectedValue)
+    public function testCastToArrayExpression($configValue, $expectedValue)
     {
         $test = $this->getTestBuilder()
             ->castToArray()
diff --git a/src/Symfony/Component/Console/Tests/TerminalTest.php b/src/Symfony/Component/Console/Tests/TerminalTest.php
@@ -60,7 +60,7 @@ public function test()
         $this->assertSame(60, $terminal->getHeight());
     }
 
-    public function test_zero_values()
+    public function testZeroValues()
     {
         putenv('COLUMNS=0');
         putenv('LINES=0');
diff --git a/src/Symfony/Component/Lock/Tests/Store/SemaphoreStoreTest.php b/src/Symfony/Component/Lock/Tests/Store/SemaphoreStoreTest.php
@@ -48,15 +48,15 @@ public function testResourceRemoval()
     private function getOpenedSemaphores()
     {
         if ('Darwin' === PHP_OS) {
-            $lines = explode(PHP_EOL, trim(`ipcs -s`));
+            $lines = explode(PHP_EOL, trim(shell_exec('ipcs -s')));
             if (-1 === $start = array_search('Semaphores:', $lines)) {
                 throw new \Exception('Failed to extract list of opened semaphores. Expected a Semaphore list, got '.implode(PHP_EOL, $lines));
             }
 
             return \count(\array_slice($lines, ++$start));
         }
 
-        $lines = explode(PHP_EOL, trim(`LC_ALL=C ipcs -su`));
+        $lines = explode(PHP_EOL, trim(shell_exec('LC_ALL=C ipcs -su')));
         if ('------ Semaphore Status --------' !== $lines[0]) {
             throw new \Exception('Failed to extract list of opened semaphores. Expected a Semaphore status, got '.implode(PHP_EOL, $lines));
         }

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ public function testThenEmptyArrayExpression()`
`149`	`149`	`/**`
`150`	`150`	`* @dataProvider castToArrayValues`
`151`	`151`	`*/`
`152`		`- public function testcastToArrayExpression($configValue, $expectedValue)`
	`152`	`+ public function testCastToArrayExpression($configValue, $expectedValue)`
`153`	`153`	`{`
`154`	`154`	`$test = $this->getTestBuilder()`
`155`	`155`	`->castToArray()`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public function test()`
`60`	`60`	`$this->assertSame(60, $terminal->getHeight());`
`61`	`61`	`}`
`62`	`62`
`63`		`- public function test_zero_values()`
	`63`	`+ public function testZeroValues()`
`64`	`64`	`{`
`65`	`65`	`putenv('COLUMNS=0');`
`66`	`66`	`putenv('LINES=0');`
Original file line number	Diff line number	Diff line change
`@@ -48,15 +48,15 @@ public function testResourceRemoval()`
`48`	`48`	`private function getOpenedSemaphores()`
`49`	`49`	`{`
`50`	`50`	`if ('Darwin' === PHP_OS) {`
`51`		- $lines = explode(PHP_EOL, trim(`ipcs -s`));
	`51`	`+ $lines = explode(PHP_EOL, trim(shell_exec('ipcs -s')));`
`52`	`52`	`if (-1 === $start = array_search('Semaphores:', $lines)) {`
`53`	`53`	`throw new \Exception('Failed to extract list of opened semaphores. Expected a Semaphore list, got '.implode(PHP_EOL, $lines));`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`return \count(\array_slice($lines, ++$start));`
`57`	`57`	`}`
`58`	`58`
`59`		- $lines = explode(PHP_EOL, trim(`LC_ALL=C ipcs -su`));
	`59`	`+ $lines = explode(PHP_EOL, trim(shell_exec('LC_ALL=C ipcs -su')));`
`60`	`60`	`if ('------ Semaphore Status --------' !== $lines[0]) {`
`61`	`61`	`throw new \Exception('Failed to extract list of opened semaphores. Expected a Semaphore status, got '.implode(PHP_EOL, $lines));`
`62`	`62`	`}`