10000 minor #29555 [WebProfilerBundle] Improve PHP extension badges (ro0NL) · symfony/symfony@da4019a · GitHub
[go: up one dir, main page]
Skip to content

Commit da4019a

Browse files
fabpotfabpot
committed
minor #29555 [WebProfilerBundle] Improve PHP extension badges (ro0NL)
This PR was merged into the 4.3-dev branch. Discussion ---------- [WebProfilerBundle] Improve PHP extension badges | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #29374 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> ![image](https://user-images.githubusercontent.com/1047696/49753655-5c70a880-fcb4-11e8-9c87-8f7586a27e5c.png) ![image](https://user-images.githubusercontent.com/1047696/49753831-cf7a1f00-fcb4-11e8-992b-fec4ed4ef4e0.png) ![image](https://user-images.githubusercontent.com/1047696/49753849-da34b400-fcb4-11e8-851c-3bfe0fc1fbfd.png) Commits ------- 4399dab [WebProfilerBundle] Fix php extension badges
2 parents d069c26 + 4399dab commit da4019a

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

‎src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/config.html.twig

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,9 @@
6464

6565
<div class="sf-toolbar-info-piece sf-toolbar-info-php-ext">
6666
<b>PHP Extensions</b>
67-
<span class="sf-toolbar-status sf-toolbar-status-{{ collector.hasxdebug ? 'green' : 'red' }}">xdebug</span>
68-
<span class="sf-toolbar-status sf-toolbar-status-{{ collector.hasapcu ? 'green' : 'red' }}">APCu</span>
69-
<span class="sf-toolbar-status sf-toolbar-status-{{ collector.haszendopcache ? 'green' : 'red' }}">OPcache</span>
67+
<span class="sf-toolbar-status sf-toolbar-status-{{ collector.hasxdebug ? 'green' : 'gray' }}">xdebug {{ collector.hasxdebug ? '✓' : '✗' }}</span>
68+
<span class="sf-toolbar-status sf-toolbar-status-{{ collector.hasapcu ? 'green' : 'gray' }}">APCu {{ collector.hasapcu ? '✓' : '✗' }}</span>
69+
<span class="sf-toolbar-status sf-toolbar-status-{{ collector.haszendopcache ? 'green' : 'red' }}">OPcache {{ collector.haszendopcache ? '✓' : '✗' }}</span>
7070
</div>
7171

7272
<div class="sf-toolbar-info-piece">
@@ -187,12 +187,12 @@
187187
</div>
188188

189189
<div class="metric">
190-
<span class="value">{{ include('@WebProfiler/Icon/' ~ (collector.hasapcu ? 'yes' : 'no') ~ '.svg') }}</span>
190+
<span class="value">{{ include('@WebProfiler/Icon/' ~ (collector.hasapcu ? 'yes' : 'no-gray') ~ '.svg') }}</span>
191191
<span class="label">APCu</span>
192192
</div>
193193

194194
<div class="metric">
195-
<span class="value">{{ include('@WebProfiler/Icon/' ~ (collector.hasxdebug ? 'yes' : 'no') ~ '.svg') }}</span>
195+
<span class="value">{{ include('@WebProfiler/Icon/' ~ (collector.hasxdebug ? 'yes' : 'no-gray') ~ '.svg') }}</span>
196196
<span class="label">Xdebug</span>
197197
</div>
198198
</div>

‎src/Symfony/Bundle/WebProfilerBundle/Resources/views/Icon/no-gray.svg

Lines changed: 5 additions & 0 deletions
Loading

0 commit comments

Comments
 (0)
0