[HttpCache] fixed if-modified-since header default to an empty string if the last-modified header was not set

akalineskou · akalineskou · commit d907bb0a59b6 · 2019-10-21T22:34:41.000+03:00
diff --git a/src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php b/src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php
@@ -5,10 +5,6 @@
  *
  * (c) Fabien Potencier <fabien@symfony.com>
  *
- * This code is partially based on the Rack-Cache library by Ryan Tomayko,
- * which is released under the MIT license.
- * (based on commit 02d2b48d75bcb63cf1c0c7149c077ad256542801)
- *
  * For the full copyright and license information, please view the LICENSE
  * file that was distributed with this source code.
  */
@@ -352,7 +348,7 @@ protected function validate(Request $request, Response $entry, $catch = false)
         }
 
         // add our cached last-modified validator
-        $subRequest->headers->set('if_modified_since', $entry->headers->get('Last-Modified'));
+        $subRequest->headers->set('if_modified_since', $entry->headers->get('Last-Modified', ''));
 
         // Add our cached etag validator to the environment.
         // We keep the etags from the client to handle the case when the client

Original file line number	Diff line number	Diff line change
`@@ -5,10 +5,6 @@`
`5`	`5`	`*`
`6`	`6`	`* (c) Fabien Potencier <fabien@symfony.com>`
`7`	`7`	`*`
`8`		`- * This code is partially based on the Rack-Cache library by Ryan Tomayko,`
`9`		`- * which is released under the MIT license.`
`10`		`- * (based on commit 02d2b48d75bcb63cf1c0c7149c077ad256542801)`
`11`		`- *`
`12`	`8`	`* For the full copyright and license information, please view the LICENSE`
`13`	`9`	`* file that was distributed with this source code.`
`14`	`10`	`*/`
`@@ -352,7 +348,7 @@ protected function validate(Request $request, Response $entry, $catch = false)`
`352`	`348`	`}`
`353`	`349`
`354`	`350`	`// add our cached last-modified validator`
`355`		`- $subRequest->headers->set('if_modified_since', $entry->headers->get('Last-Modified'));`
	`351`	`+ $subRequest->headers->set('if_modified_since', $entry->headers->get('Last-Modified', ''));`
`356`	`352`
`357`	`353`	`// Add our cached etag validator to the environment.`
`358`	`354`	`// We keep the etags from the client to handle the case when the client`