minor #58788 [Mailer] use microsecond precision SMTP logging (0xb4lint)

fabpot · fabpot · commit d8f80807b105 · 2024-11-09T07:58:11.000+01:00
This PR was squashed before being merged into the 7.2 branch. Discussion ---------- [Mailer] use microsecond precision SMTP logging | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Replaced `date('c')` with `(new \DateTimeImmutable())->format('Y-m-d\TH:i:s.up')` to have microsecond precision. Before: `2024-11-06T12:57:35+00:00` (ISO 8601) After: `2024-11-06T12:57:35.123456Z` (ISO 8601 with microseconds) This change makes possible to inspect each SMTP command's time consumption. Commits ------- 6d8c53e [Mailer] use microsecond precision SMTP logging
diff --git a/src/Symfony/Component/Mailer/Transport/Smtp/Stream/AbstractStream.php b/src/Symfony/Component/Mailer/Transport/Smtp/Stream/AbstractStream.php
@@ -37,7 +37,7 @@ abstract class AbstractStream
     public function write(string $bytes, bool $debug = true): void
     {
         if ($debug) {
-            $timestamp = date('c');
+            $timestamp = (new \DateTimeImmutable())->format('Y-m-d\TH:i:s.up');
             foreach (explode("\n", trim($bytes)) as $line) {
                 $this->debug .= \sprintf("[%s] > %s\n", $timestamp, $line);
             }
@@ -93,7 +93,7 @@ public function readLine(): string
             }
         }
 
-        $this->debug .= \sprintf('[%s] < %s', date('c'), $line);
+        $this->debug .= \sprintf('[%s] < %s', (new \DateTimeImmutable())->format('Y-m-d\TH:i:s.up'), $line);
 
         return $line;
     }

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ abstract class AbstractStream`
`37`	`37`	`public function write(string $bytes, bool $debug = true): void`
`38`	`38`	`{`
`39`	`39`	`if ($debug) {`
`40`		`- $timestamp = date('c');`
	`40`	`+ $timestamp = (new \DateTimeImmutable())->format('Y-m-d\TH:i:s.up');`
`41`	`41`	`foreach (explode("\n", trim($bytes)) as $line) {`
`42`	`42`	`$this->debug .= \sprintf("[%s] > %s\n", $timestamp, $line);`
`43`	`43`	`}`
`@@ -93,7 +93,7 @@ public function readLine(): string`
`93`	`93`	`}`
`94`	`94`	`}`
`95`	`95`
`96`		`- $this->debug .= \sprintf('[%s] < %s', date('c'), $line);`
	`96`	`+ $this->debug .= \sprintf('[%s] < %s', (new \DateTimeImmutable())->format('Y-m-d\TH:i:s.up'), $line);`
`97`	`97`
`98`	`98`	`return $line;`
`99`	`99`	`}`