merged branch ricardclau/improve-luhn-validator (PR #6591)

fabpot · fabpot · commit d8be36cf8493 · 2013-01-07T08:07:44.000+01:00
This PR was merged into the master branch. Commits ------- b1f190f covers edge case for Luhn Discussion ---------- [Validator] Covering edge case for Luhn when checksum is exactly 0 Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: Todo: License of the code: MIT Documentation PR: Actually not a big deal, but a Credit Card with all 0s passed validation. Now this is covered.
diff --git a/src/Symfony/Component/Validator/Constraints/LuhnValidator.php b/src/Symfony/Component/Validator/Constraints/LuhnValidator.php
@@ -51,7 +51,7 @@ public function validate($value, Constraint $constraint)
             $sum += (($i % 2) === $oddLength) ? array_sum(str_split($digit * 2)) : $digit;
         }
 
-        if (($sum % 10) !== 0) {
+        if ($sum === 0 || ($sum % 10) !== 0) {
             $this->context->addViolation($constraint->message);
         }
     }
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/LuhnValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/LuhnValidatorTest.php
@@ -102,6 +102,8 @@ public function getInvalidNumbers()
         return array(
             array('1234567812345678'),
             array('4222222222222222'),
+            array('0000000000000000'),
+            array(0),
         );
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public function validate($value, Constraint $constraint)`
`51`	`51`	`$sum += (($i % 2) === $oddLength) ? array_sum(str_split($digit * 2)) : $digit;`
`52`	`52`	`}`
`53`	`53`
`54`		`- if (($sum % 10) !== 0) {`
	`54`	`+ if ($sum === 0 \|\| ($sum % 10) !== 0) {`
`55`	`55`	`$this->context->addViolation($constraint->message);`
`56`	`56`	`}`
`57`	`57`	`}`
Original file line number	Diff line number	Diff line change
`@@ -102,6 +102,8 @@ public function getInvalidNumbers()`
`102`	`102`	`return array(`
`103`	`103`	`array('1234567812345678'),`
`104`	`104`	`array('4222222222222222'),`
	`105`	`+ array('0000000000000000'),`
	`106`	`+ array(0),`
`105`	`107`	`);`
`106`	`108`	`}`
`107`	`109`	`}`