bug #41553 [Messenger] fix BC for FrameworkBundle 4.4 with a non-existence alias being used (monteiro)

nicolas-grekas · nicolas-grekas · commit d85847c84127 · 2021-06-08T16:01:11.000+02:00
This PR was squashed before being merged into the 5.3 branch. Discussion ---------- [Messenger] fix BC for FrameworkBundle 4.4 with a non-existence alias being used | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | Fix #41545 ...  | License | MIT When trying to update symfony/messenger to 5.3 while still using symfony/framework-bundle 4.4 there is an error: The service "console.command.messenger_failed_messages_retry" has a dependency on a non-existent service "messenger.failure_transports.default". This is because in Symfony Messenger 5.3, on the PR #38468 to support multiple failure transports we have created an alias, that is only available on the FrameworkBundle 5.3. This fix will use an already existence alias. Sample project to test this behavior: https://github.com/monteiro/PR-41553-symfony Commits ------- aa0e166 [Messenger] fix BC for FrameworkBundle 4.4 with a non-existence alias being used
diff --git a/src/Symfony/Component/Messenger/DependencyInjection/MessengerPass.php b/src/Symfony/Component/Messenger/DependencyInjection/MessengerPass.php
@@ -260,7 +260,11 @@ private function registerReceivers(ContainerBuilder $container, array $busIds)
             $commandDefinition = $container->getDefinition('console.command.messenger_failed_messages_retry');
             $globalReceiverName = $commandDefinition->getArgument(0);
             if (null !== $globalReceiverName) {
-                $failureTransportsMap[$commandDefinition->getArgument(0)] = new Reference('messenger.failure_transports.default');
+                if ($container->hasAlias('messenger.failure_transports.default')) {
+                    $failureTransportsMap[$globalReceiverName] = new Reference('messenger.failure_transports.default');
+                } else {
+                    $failureTransportsMap[$globalReceiverName] = new Reference('messenger.transport.'.$globalReceiverName);
+                }
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,11 @@ private function registerReceivers(ContainerBuilder $container, array $busIds)`
`260`	`260`	`$commandDefinition = $container->getDefinition('console.command.messenger_failed_messages_retry');`
`261`	`261`	`$globalReceiverName = $commandDefinition->getArgument(0);`
`262`	`262`	`if (null !== $globalReceiverName) {`
`263`		`- $failureTransportsMap[$commandDefinition->getArgument(0)] = new Reference('messenger.failure_transports.default');`
	`263`	`+ if ($container->hasAlias('messenger.failure_transports.default')) {`
	`264`	`+ $failureTransportsMap[$globalReceiverName] = new Reference('messenger.failure_transports.default');`
	`265`	`+ } else {`
	`266`	`+ $failureTransportsMap[$globalReceiverName] = new Reference('messenger.transport.'.$globalReceiverName);`
	`267`	`+ }`
`264`	`268`	`}`
`265`	`269`	`}`
`266`	`270`